[$500] Workspace - Tooltip is at the center instead of above display name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: .1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Open workspace switcher
3. Select a workspace
4. Go to Settings at the bottom
5. Go to Members
6. Hover over member display name

Expected Result:

Tooltip appeaers above the display name

Actual Result:

Tooltip is at the center instead of above the display name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365133_1706896814542.20240203_001655.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da161df451d2ec58
• Upwork Job ID: 1753485595100897280
• Last Price Increase: 2024-02-02

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #5
CC @dylanexpensify

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip is at the center instead of above display name

What is the root cause of that problem?

We place the Tootip at wrong component

What changes do you think we should make in order to solve the problem?

Rearrange the tooltip to be placed exactly above the text

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01da161df451d2ec58

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[hayata-suenaga]

seems like from the Ideal Navigation PR? Removing the blocker as this is just a UI bug. I'll track this as part of the Ideal Nav regressions

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Tooltip is at the center instead of above display name

What is the root cause of that problem?

This issue happens because the text container inside MenuItem takes full width available.

What changes do you think we should make in order to solve the problem?

Set the text container width to fitContent.

Result

[mkhutornyi]

@hayata-suenaga this is not related to Ideal Nav.
Regression from #34197
Original author/reviewer should handle this

[shubham1206agra]

Interesting. But I am not sure if we should treat this as regression from #34197 as they can't test this on Ideal Nav due to PR timings.

[mkhutornyi]

This also happens on Invite members page which isn't part of Ideal Nav.
This should have been easily caught during PR review.

[mkhutornyi]

cc: @aswin-s @sobitneupane

[hayata-suenaga]

ah should I remove this from ideal nav then?

[shubham1206agra]

Oh. If that's the case, then I will unassign myself from this issue and let @sobitneupane take over.
cc @hayata-suenaga

[shubham1206agra]

ah should I remove this from ideal nav then?

Yes

[hayata-suenaga]

cc: @sobitneupane

[aswin-s]

I'll raise a fix shortly

[aswin-s]

PR is ready: #35735 @sobitneupane

[roryabraham]

IDK why, but I'm not able to get tooltips to show up on this view at all 😕

[roryabraham]

the only tooltip I see is this one:

same on main and on @aswin-s' branch

[mountiny]

Same as Rory, only that one tooltip

[aswin-s]

@sobitneupane @roryabraham Looks like hiding the tooltip is intentional. Regression is from #35460. As per issue #34961 it shouldn't even show tooltip here as the label and tooltip is same.

So is this issue valid any more?

[sobitneupane]

@aswin-s Going through the linked PR, we do show the tooltip, If target.scrollWidth > target.offsetWidth (i.e., if the text overflows).

Screen.Recording.2024-02-07.at.12.27.40.mov

But I do believe that in case the text overflows, the tooltip will basically appear at the center. But we should extensively test different cases with larger text and alternate texts.

[aswin-s]

@sobitneupane The scenario where text overflows is when the text length reaches the container width. At this point tool tip should be aligned at the center of the container anyways.

[roryabraham]

cool, so it sounds like this issue is no longer valid.