Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIGH: [Public] Make all workspace room members "known" to the admins #35539

Closed
quinthar opened this issue Feb 1, 2024 · 6 comments
Closed

HIGH: [Public] Make all workspace room members "known" to the admins #35539

quinthar opened this issue Feb 1, 2024 · 6 comments
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@quinthar
Copy link
Contributor

quinthar commented Feb 1, 2024

Problem:
A workspace owner pays for activity in their workspace room. And anybody can invite anyone to that room. When you do, it notifies admins that someone has been invited in the #admins room. However, because the admins have no relationship with the invited person, the invited person shows as "Hidden".

Solution:
If Alice invites Bob to a room, and Cathy is the workspace admin, then Cathy should "know" Bob and see Bob's primary login. After all, Alice could have only invited Bob using Bob's primary login, so by inviting him, she's in effect introduced Bob to Cathy.

@puneetlath
Copy link
Contributor

Issue for query timing here: https://github.com/Expensify/Expensify/issues/373736

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@puneetlath
Copy link
Contributor

Continuing to work on the query.

@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2024
@puneetlath
Copy link
Contributor

Will start working on this again soon.

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2024
@quinthar quinthar changed the title HIGH: Make all workspace room members "known" to the admins HIGH: [Security] Make all workspace room members "known" to the admins Mar 25, 2024
@quinthar quinthar changed the title HIGH: [Security] Make all workspace room members "known" to the admins HIGH: [Public] Make all workspace room members "known" to the admins Mar 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

This issue has not been updated in over 15 days. @puneetlath eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@puneetlath puneetlath added Weekly KSv2 Reviewing Has a PR in review Engineering and removed Monthly KSv2 labels Apr 15, 2024
@puneetlath
Copy link
Contributor

Ok PR is in review: https://github.com/Expensify/Auth/pull/10537

@puneetlath
Copy link
Contributor

PR was deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

2 participants