Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - System message for room name change shows "renamed from #B to #B" #35323

Closed
6 tasks done
lanitochka17 opened this issue Jan 29, 2024 · 12 comments
Closed
6 tasks done
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.32-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Create a room with name A
  2. Go to room header
  3. Go to Settings
  4. Click Room name
  5. Change to name B
  6. Return to room chat

Expected Result:

The system message says "You renamed this room from #nameA to #nameB

Actual Result:

The system message says "You renamed this room from #nameB to #nameB"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6359781_1706547581377.20240130_003731.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 29, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 29, 2024

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp.
CC @quinthar

@dummy-1111
Copy link
Contributor

This isn't reproducible on the latest main

@lanitochka17
Copy link
Author

Issue is not reproducible on Production

20240130_004449.mp4

@dummy-1111
Copy link
Contributor

This issue is related to the backend. This happens when we use staging backend

@francoisl
Copy link
Contributor

Can confirm this is a backend issue, working on a fix.

@francoisl francoisl self-assigned this Jan 29, 2024
@francoisl
Copy link
Contributor

Anyway, not a deploy blocker for NewDot.

@francoisl francoisl added Reviewing Has a PR in review and removed DeployBlockerCash This issue or pull request should block deployment labels Jan 29, 2024
@hayata-suenaga
Copy link
Contributor

@s-alves10 does this only happen on staging backend and not production backend?

@hayata-suenaga hayata-suenaga added Daily KSv2 and removed Hourly KSv2 labels Jan 29, 2024
@hayata-suenaga
Copy link
Contributor

PR to fix the backend was merged

Copy link

melvin-bot bot commented Feb 6, 2024

@francoisl, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@francoisl
Copy link
Contributor

Backend fix is deployed to production already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants