[HOLD for payment 2024-02-05] [HOLD for payment 2024-02-01] Group chat - Group chat shows only creator avatar in LHN and creator in member list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.31-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Click FAB > Start chat
2. Select a few users and create the group chat
3. Click on the chat header
4. Click Members

Expected Result:

In Step 2, the group chat will show the avatar of current user with +n indicator
In Step 4, member list will include all the members involved

Actual Result:

In Step 2, the group chat only shows the group creator avatar
In Step 4, member list only includes the group creator

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6353432_1706113774370.20240124_195811__1_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[arosiclair]

Reproduced on staging v1.4.31-4

[arosiclair]

Definitely seems to be a backend issue in OpenReport as there are a bunch of duplicate/unnecessary Onyx updates in there.

Confirmed by the issue only being reproduced after coming back online:

Screen.Recording.2024-01-24.at.12.59.02.PM.mov

[arosiclair]

Okay this seems to be caused by ReportUtils.getVisibleMemberIDs. It uses report.visibleChatMemberAccountIDs but this is empty for group chats. That doesn't seem right, but that is how both staging and prod APIs behave so this just seems to be a regression from #34237.

Reverting the PR fixes the issue:

cc @FitseTLT @akinwale @MonilBhavsar

[arosiclair]

Revert is here.

@MonilBhavsar I don't have all of the context, but ReportUtils.getVisibleMemberIDs looks like data massaging and seems wrong to me. I think we should fix our Onyx updates to send this array correctly for all types of reports so there's no need for that function.

[thienlnam]

Merged and CPed - thanks @arosiclair!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.31-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #34237 from FitseTLT/fix-include-current-u… #35099

If no regressions arise, payment will be issued on 2024-02-01. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #34237 from FitseTLT/fix-include-current-u… #35099

If no regressions arise, payment will be issued on 2024-02-05. 🎊

[arosiclair]

This is all done