[HOLD for payment 2024-01-25] [$500] Web/Safari - Attachment - Drag and drop popup does not show on Safari

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.24-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Drag and attachment to any chat

---

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Click on "+" > Request money > Scan module
4. Drag and attachment to the scan module

Expected Result:

User expects there to be a "Drag to upload" popup (Or "+" symbol for the first case) and in the second case a popup that says "Let it go - drag to up upload)

Actual Result:

No popup is shown when dragging and dropping, there is a "+" symbol but this shows ups and then after a while for no reason disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6338796_1704974893161.No_popup_when_dragging_and_dropping_on_Safari.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018eedacd3a9252d63
• Upwork Job ID: 1745435828436111360
• Last Price Increase: 2024-01-11
• Automatic offers:
• s77rt | Contributor | 28102162
• tienifr | Contributor | 28102165

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018eedacd3a9252d63

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[bernhardoj]

regression from #33864

[s77rt]

@tienifr Can you please take a look at this

[melvin-bot]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@kadiealexander / @amyevans Please assign me and @tienifr here

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[amyevans]

Thanks for jumping on it so quickly @tienifr and @s77rt!

PS I can't assign you until you comment here @tienifr.

[tienifr]

I'm here

[tienifr]

@amyevans

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: drag drop file safari #34406

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment automatic offer (Contributor)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Fix: Drop file here modal does not dismiss when file is no longer dragged over the area #33864
• The offending PR has been commented on: n/a
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No. We have a test already https://expensify.testrail.io/index.php?/cases/view/2730088

[s77rt]

@amyevans Please close this, no payment to handle here since it's a regression.