Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Money Request - Green dot doesn't appear after Money Request in LHN #31222

Closed
6 tasks done
lanitochka17 opened this issue Nov 10, 2023 · 11 comments
Closed
6 tasks done

Money Request - Green dot doesn't appear after Money Request in LHN #31222

lanitochka17 opened this issue Nov 10, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.98-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch App
  2. Create new workspace
  3. Request money on that workspace
  4. Return to LHN

Expected Result:

Verify that green dot shows in LHN for the money request report row

Actual Result:

The green dot doesn't appear after Money Request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271923_1699656146284.RPReplay_Final1699654651.1.mp4

Bug6271923_1699656146317!1

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jasperhuangg
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 10, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@miljakljajic
Copy link
Contributor

This wasn't assigned til 11pm my time on Friday, sorry to get to it so late - @jasperhuangg do you agree this is a deploy blocker?

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@miljakljajic
Copy link
Contributor

Not reproducible on staging:

image

@miljakljajic miljakljajic changed the title Money Request - Green dot doesn't appeared after Money Request in LHN Money Request - Green dot doesn't appear after Money Request in LHN Nov 13, 2023
@roryabraham
Copy link
Contributor

roryabraham commented Nov 14, 2023

I was able to reproduce this on staging, but I was requesting money from a workspace I owned:

image

Edit: refreshed the page and the green dot appeared

@jasperhuangg
Copy link
Contributor

Hey sorry for the delay on this, I just tried it out and was also able to reproduce it.

The GBR appears on the workspace chat, but not on the actual expense report it seems. This was also with a workspace that I owned.

I'm going to be OOO today, so I’m going to unassign this, @roryabraham do you think you could take this off my hands please?

@mountiny
Copy link
Contributor

Its expected to show on the workspace chat now, this is part of the wave6 changes we are making

@mountiny
Copy link
Contributor

I cannot reproduce this either
image

The green dot is showing correctly on the LHN for the parent chat

@mountiny mountiny assigned mountiny and unassigned jasperhuangg Nov 14, 2023
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 14, 2023
@mountiny
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants