[HOLD for payment 2023-12-12] Task - Assignee with custom avatar shows default avatar in the task report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: .3.96-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30515

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to chat with user that has a custom avatar
3. Click + > Assign task
4. Create a task and assign the same user in Step 1 as assignee
5. Open the task report

Expected Result:

The assignee in the task report shows the custom avatar

Actual Result:

The assignee in the task report shows the default avatar instead of the custom avatar

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267894_1699387235985.20231108_033932.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task asignee with custom avator shows the default avatar in the task report view

What is the root cause of that problem?

in the following line, the props.personalDetails is undefined because we dont connect to onyx to get the personal details object:

App/src/components/ReportActionItem/TaskView.js

Line 150 in 5d45f0f

icon={OptionsListUtils.getAvatarsForAccountIDs([props.report.managerID], props.personalDetails)}

What changes do you think we should make in order to solve the problem?

either by adding:

    const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;

and update the line above to use this const

OR by connecting to the onyx in the component:

     withOnyx({
         personalDetails: {
             key: ONYXKEYS.PERSONAL_DETAILS_LIST,
         },
     }),

Or alternatively we add those in the withCurrentUserPersonalDetails hoc

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee with custom avatar shows default avatar in the task report

What is the root cause of that problem?

#30354

In this PR we remove personalDetails from Onyx and use hook to get this. And then we don't pass this to WrappedComponent

App/src/components/withCurrentUserPersonalDetails.tsx

Line 36 in c2e4042

const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;

That makes props.personalDetails is undefined and then default avatar is displayed

App/src/components/ReportActionItem/TaskView.js

Line 50 in c2e4042

const assigneeTooltipDetails = ReportUtils.getDisplayNamesWithTooltips(OptionsListUtils.getPersonalDetailsForAccountIDs([props.report.managerID], props.personalDetails), false);

What changes do you think we should make in order to solve the problem?

1. If we don't want to pass personalDetails from withCurrentUserPersonalDetails to WrappedComponent, we should search all pages that are using this HOC and replace props.personalDetails with usePersonalDetails() hook

2. We should pass personalDetails to WrappedComponent in withCurrentUserPersonalDetails HOC

App/src/components/withCurrentUserPersonalDetails.tsx

Line 36 in c2e4042

const personalDetails = usePersonalDetails() ?? CONST.EMPTY_OBJECT;

What alternative solutions did you explore? (Optional)

[isabelastisser]

Hey @Li357, what's the next step here? Did you review the proposals above? Thanks!

[Li357]

Both proposals had the correct RCA, so I'm going to go with @abzokhattab who was first. Can we make sure to do what @dukenv0307 suggest though, to use the hook everywhere we have the HOC withCurrentUserPersonalDetails? I think uniformity and moving to functional components is the goal here.

[puneetlath]

Given this relates to tasks, I"m going to remove it as a deploy blocker. Let's still fix it asap though.

[abzokhattab]

Here are the changes #31076 will add the screenshots/tests and mark it as ready

[rushatgabhane]

@abzokhattab is the PR ready for review? Please change the status

[abzokhattab]

PR is ready

[abzokhattab]

Also please note that the offer has not been sent yet

[isabelastisser]

PR has not merged yet. I will create the offer when the payment is due.

[abzokhattab]

hey @isabelastisser the pr is deployed on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Introducing usePersonalDetails hoc in places that use withCurrentUserPersonalDetails HOC #31076

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Li357 requires payment
• @abzokhattab requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Li357 / @abzokhattab] Determine if we should create a regression test for this bug.
• [@Li357 / @abzokhattab] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

Not overdue, payment on Dec 12.

[isabelastisser]

@abzokhattab, can you please complete the checklist above?

Payment is due tomorrow.

[abzokhattab]

Hi @isabelastisser I guess you meant @Li357 right?

[isabelastisser]

Hey @abzokhattab, @Li357 is no longer working for Expensify. Can you please complete the checklist? Thanks!

[isabelastisser]

Offer sent in Upwork.

[abzokhattab]

Thanks @isabelastisser I don't think we need a regression test for this as the changes included minor refactoring.

[isabelastisser]

Sounds good. All set!