[$500] Chat - Composer not focused after using the Mini context menu

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Send a message and click anywhere on the page to lose composer focus
3. Hover over the message and from the Mini context menu click on Copy to the clipboard or Mark as unread

• If we Copy to the clipboard or Mark as unread from the Context menu(By right-clicking) The composer is refocused

Expected Result:

Composer is focused after using the Mini context menu the same as using the Context menu(By right-clicking)

Actual Result:

Composer not focused after using the Mini context menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.70-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T145composerfocus-1.mp4

Recording.1522.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694056716395569

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0112d0966800e14318
• Upwork Job ID: 1702285337991520256
• Last Price Increase: 2023-09-28

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0112d0966800e14318

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Composer not focused after using the Mini context menu

What is the root cause of that problem?

Focusing on composer is only done as callback for popups:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 214 to 216 in 95c9e47

	if (closePopover) {
	hideContextMenu(true, ReportActionComposeFocusManager.focus);
	}

What changes do you think we should make in order to solve the problem?

We need to implement composer focus on other context menu than popups too (i.e. mini context menu):

             if (closePopover) {
                hideContextMenu(true, ReportActionComposeFocusManager.focus);
            } else {
                ReportActionComposeFocusManager.focus()
            }

What alternative solutions did you explore? (Optional)

N/A

[needpower]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer is not re-focused after the 'Copy to clipboard' and 'Mark as unread' commands using the Mini context menu.

What is the root cause of that problem?

The ContextMenuActions component defined a behavior for all context menu items, including those mentioned in the bug.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 172 to 185 in 6764fd1

	isAnonymousAction: true,
	textTranslateKey: 'reportActionContextMenu.copyToClipboard',
	icon: Expensicons.Copy,
	successTextTranslateKey: 'reportActionContextMenu.copied',
	successIcon: Expensicons.Checkmark,
	shouldShow: (type, reportAction) =>
	type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
	!ReportUtils.isReportMessageAttachment(_.last(lodashGet(reportAction, ['message'], [{}]))) &&
	!ReportActionsUtils.isMessageDeleted(reportAction),
	// If return value is true, we switch the `text` and `icon` on
	// `ContextMenuItem` with `successText` and `successIcon` which will fallback to
	// the `text` and `icon`
	onPress: (closePopover, {reportAction, selection}) => {

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 246 to 252 in 6764fd1

	isAnonymousAction: false,
	textTranslateKey: 'reportActionContextMenu.markAsUnread',
	icon: Expensicons.Mail,
	successIcon: Expensicons.Checkmark,
	shouldShow: (type, reportAction, isArchivedRoom, betas, anchor, isChronosReport, reportID, isPinnedChat, isUnreadChat) =>
	type === CONTEXT_MENU_TYPES.REPORT_ACTION || (type === CONTEXT_MENU_TYPES.REPORT && !isUnreadChat),
	onPress: (closePopover, {reportAction, reportID}) => {

The logic explicitly tells that re-focus should happen only when the context menu is in popover form (right-click):

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Line 85 in 95c9e47

const closePopup = !props.isMini;

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 214 to 216 in 95c9e47

	if (closePopover) {
	hideContextMenu(true, ReportActionComposeFocusManager.focus);
	}

What changes do you think we should make in order to solve the problem?

Use existing FocusManager and trigger re-focus regardless of the closePopover boolean flag. This also brings consistency across the platform.

What alternative solutions did you explore? (Optional)

N/A

[hjchoudry]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Composer not focused after using the Mini context menu

What is the root cause of that problem?

Focusing on the composer is only done as a callback for popups, not on the mini context menu:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 111 to 113 in 95c9e47

	if (closePopover) {
	hideContextMenu(true, ReportActionComposeFocusManager.focus);
	}

What changes do you think we should make in order to solve the problem?

Use existing ReportActionComposeFocusManager.focus and trigger re-focus ReportActionComposeFocusManager.focus regardless of the closePopover boolean flag.

Add this to each menu item in the onPress function at the end
ReportActionComposeFocusManager.focus

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @hjchoudry! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[hjchoudry]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0179674adb1f8399c7

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[sophiepintoraetz]

Waiting on reviews from @Ollyws

[Ollyws]

I'm a little skeptical if this is a legit bug worth fixing. I assumed the reason we focus after using the right-click context menu is because using it blurs the composer which should then be re-focused, but in the case of the mini-context-menu the composer is not blurred when it's used.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sophiepintoraetz]

I'm wondering if it's a consistency thing though, right @Ollyws? Though I could be misunderstanding the significance of in the case of the mini-context-menu the composer is not blurred when it's used.

[melvin-bot]

@Ollyws, @sophiepintoraetz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sophiepintoraetz]

Waiting on @Ollyws to come back to me.

[Ollyws]

Asked in slack.

[melvin-bot]

@Ollyws @sophiepintoraetz this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Ollyws]

I think as per the slack convo we're good to close this one.

[sophiepintoraetz]

Agreed - thanks Olly for checking! I also need to wrap up these focus issues and perhaps put a pause on them because we're pretty inconsistent on how we fix them