[HOLD for payment 2023-09-27] Unable to send attachment and new message is not shown in LHN after sending attachment

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to an existing conversation
2. Click the plus icon -> Add attachment -> Choose from gallery
3. Select any photo -> Send
4. Then send a message to this chat

Expected Result:

The selected photo will be sent within seconds. The message sent should show in the LHN

Actual Result:

The selected photo is not sent. The message sent after not showing in the LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari (@tgolen able to reproduce)
• MacOS / Desktop

Version Number: 1.3.67-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

nganngok.mp4

az_recorder_20230911_112658.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thuyle04
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694407887187689

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

this is fixed here #24246 PR in review

[tgolen]

I think the problem I was seeing is related to some of the pusher/https updates @danieldoglas and I have been making. I saw a console log for [SequentialQueue] Pausing the queue but it never became unpaused. There should eventually be a corresponding log like [SequentialQueue] Unpausing the queue and flushing 0 requests.

I was able to log off refresh, and log back on and that fixed the issue for me now.

[jasperhuangg]

@tgolen Do you think we should be blocking deploy on this? Based on #24246 it also seems like this is a dupe.

[tgolen]

Yes, It needs to be a blocker. I do not think it is a duplicate and that sounds like a different issue. I am going to revert the ordered-updates PR which should solve this.

[tgolen]

We discussed in Slack and since this is related to a beta, and there is a workaround (logoff/logon), we are not going to revert, and we are just going to close this issue as won't fix.

[tgolen]

Daniel has a fix for this, so we are going to implement it and reopen this.

[danieldoglas]

This was merged, will reach prod soon

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Properly handle previous data formats when saving the updates from the server to Onyx #27180

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @thuyle04 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@danieldoglas] The PR that introduced the bug has been identified. Link to the PR:
• [@danieldoglas] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@danieldoglas] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@danieldoglas] Determine if we should create a regression test for this bug.
• [@danieldoglas] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[thuyle04]

@danieldoglas Do you have any payment for bug reporter, please?

[danieldoglas]

@garrettmknight I just reassigned you, can you please deal with the bug reporter payment here?

[garrettmknight]

@thuyle04 offer sent, please accept.

https://www.upwork.com/en-gb/ab/applicants/1709656006752256000/job-details

[thuyle04]

@garrettmknight Hi, I can't access this url with my appropriate account.

[garrettmknight]

@thuyle04 sorry, the URL was for me!

Summary of payments:

• Reporter: @thuyle04 paid $50 via upwork