[HOLD for payment 2023-09-20] Pay button doesn't match system message

[JmillsExpensify]

When paying reports, we have a button that looks like this.

However, when you actually pay the report the system message is different.

Accordingly, let's fix this inconsistency and ensure that the system message matches the button. Given that we are deprecating Paypal.me, and related, with Paid %amount% elsewhere not having this problem, I think this system message for in-product payments is all we need to fix.

-Paid %amount% with Expensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010cef4a98f0f3cb6d
• Upwork Job ID: 1700038463323570176
• Last Price Increase: 2023-09-08

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay button doesn't match system message

What is the root cause of that problem?

App/src/languages/en.ts

Line 523 in b119f9a

paidUsingExpensifyWithAmount: ({amount}: PaidUsingExpensifyWithAmountParams) => `paid ${amount} using Expensify`,

App/src/libs/ReportUtils.js

Line 1454 in b119f9a

} else if (reportActionMessage.match(/ using Expensify$/)) {

App/src/libs/ReportUtils.js

Line 2015 in b119f9a

paymentMethodMessage = ' using Expensify';

We are using "using Expensify" instead of "with Expensify"

What changes do you think we should make in order to solve the problem?

Update all above places to "with Expensify"

In es.js

App/src/languages/es.ts

Line 524 in b119f9a

paidUsingExpensifyWithAmount: ({amount}: PaidUsingExpensifyWithAmountParams) => `pagó ${amount} con Expensify`,

we also should consider updating es.js

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010cef4a98f0f3cb6d

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[mountiny]

This also needs to be fixed in the backend I believe

[melvin-bot]

@JmillsExpensify, @mountiny, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

Working on this one

[mountiny]

PR in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update the paid message to use same language as the button #27006

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@JmillsExpensify, @allroundexperts, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify, @allroundexperts, @mountiny 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@JmillsExpensify, @allroundexperts, @mountiny Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@JmillsExpensify, @allroundexperts, @mountiny 12 days overdue now... This issue's end is nigh!

[mountiny]

$500 to @allroundexperts for internal review.

[JmillsExpensify]

$500 payment approved for @allroundexperts based on BZ summary.

[JmillsExpensify]

@allroundexperts can you also make sure to comment as to whether a regression test is required?

[mountiny]

@allroundexperts I think it would be good to add a regression test for this, would you be able to write it down based on the PR QA steps? Thank you!

[JmillsExpensify]

Agree that we should add a regression test for this. @allroundexperts can you suggest one?

[allroundexperts]

Regression Test

1. Login to the app as Account A and set up the Workspace with a bank account (if you don't have one already)
2. Invite a member (Account B) to the workspace.
3. Login as Account B and add a bank account for reimbursement
4. Request money from the created workspace as Account B.
5. Login to Account A, go to the created workspace and pay with Expensify
6. Verify that the system message also says "paid xxxx with Expensify"
7. Login to Account B again and verify that the message says the same as above.

Do we 👍 or 👎 ?

[JmillsExpensify]

That looks good to me. Thank you! Just added a regression test.

[JmillsExpensify]

Payment summary: $500 to @allroundexperts for PR review.

[JmillsExpensify]

Closing this out, as it's paid via NewDot. Please don't forget to add a request!

[JmillsExpensify]

$500 payment approved for @allroundexperts based on summary above.