Android- IOU- User is allowed to select while creating distance IOU

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap Fab
3. Tap request money
4. Tap distance
5. Tap Start and select an address
6. Tap Finish and select an address
7. Tap Next
8. Enter any user email address and select it

Expected Result:

User must not be allowed to select while creating distance IOU. Only Workspace should be allowed to create distance IOU.

Actual Result:

User is allowed to select while creating distance IOU.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.65-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6191082_contact.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is allowed to select while creating distance IOU

What is the root cause of that problem?

We haven't excluded user options in the search results for distance IOU.

What changes do you think we should make in order to solve the problem?

We should pass canInviteUser = false to here if props.isDistanceRequest.
We also should change the text input label Name, email, or phone number.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Misleading- Distance request money does not work with email & phone number

What is the root cause of that problem?

In MoneyRequestParticipantsSelector, We disable the P2P option here but we don't exclude the invited user for distance request

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 93 in db1a306

!this.props.isDistanceRequest,

What changes do you think we should make in order to solve the problem?

In MoneyRequestParticipantsSelector, we should pass canInviteUser params as false here to exclude the invited user option for distance request.

return OptionsListUtils.getNewChatOptions(
  this.props.reports,
  this.props.personalDetails,
  this.props.betas,
  searchTerm,
  [],
  CONST.EXPENSIFY_EMAILS,

  // If we are using this component in the "Request money" flow then we pass the includeOwnedWorkspaceChats argument so that the current user
  // sees the option to request money from their admin on their own Workspace Chat.
  this.props.iouType === CONST.IOU.MONEY_REQUEST_TYPE.REQUEST,

  // We don't want to include any P2P options like personal details or reports that are not workspace chats for certain features.
  !this.props.isDistanceRequest,
  false,
  {},
  [],
  !this.props.isDistanceRequest
);

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 93 in db1a306

!this.props.isDistanceRequest,

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.07-09-2023.16.47.27.webm

[trjExpensify]

Not worth proceeding with this issue, in light of this: #23291

CC: @JmillsExpensify

[joekaufmanexpensify]

Cool, makes sense. Closing!