Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Next button while creating split bill is not at bottom #26510

Closed
1 of 6 tasks
kbecciv opened this issue Sep 1, 2023 · 6 comments
Closed
1 of 6 tasks

Web - Next button while creating split bill is not at bottom #26510

kbecciv opened this issue Sep 1, 2023 · 6 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Start split bill workflow
  2. After selecting members

Expected Result:

Split bill button should be at bottom

Actual Result:

it's not at bottom

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.61.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-01.at.11.38.04.PM.mov

image

Expensify/Expensify Issue URL:
Issue reported by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693591772083449

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 1, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@BhuvaneshPatil
Copy link
Contributor

BhuvaneshPatil commented Sep 1, 2023

Proposal

Can create a PR ASAP if required

Please re-state the problem that we are trying to solve in this issue.

Next button while creating split bill is not at bottom

What is the root cause of that problem?

Regression from #26179
Because of added ScrollView, it's not taking full height.

What changes do you think we should make in order to solve the problem?

We should make this flex grow

in MoneyRequestConfirmPage

<ScrollView contentContainerStyle={[styles.flexGrow1]}>
                        <ScrollView
                            horizontal
                            contentContainerStyle={[styles.flex1, styles.flexColumn]}
                        >

result -
Screenshot 2023-09-02 at 12 18 31 AM

What alternative solutions did you explore? (Optional)

@BhuvaneshPatil
Copy link
Contributor

Same issue happens in RequestMoney Flow as well

@kbecciv
Copy link
Author

kbecciv commented Sep 1, 2023

Duplicate #26418

@kbecciv
Copy link
Author

kbecciv commented Sep 1, 2023

Closing because of duplicate

@kbecciv kbecciv closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants