[HOLD for payment 2023-09-04] BA - Expensify crashes when entering test transactions

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com or start Expensify App
2. Login with Expensifail account
3. Create new or go to existing workspace without BA
4. Go to Workspace > Connect bank account
5. Select the Manual method to add a bank account
6. Follow the flow to connect Pending State Bank account' until 'Test transactions' page
7. Enter any numbers in the test transaction fields

Expected Result:

User can enter test transactions

Actual Result:

App / Website crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

logs.log

Notes/Photos/Videos: Any additional supporting documentation

Bug6173650_T3604598-Crash-Test-Transactions.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

logs.log

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hayata-suenaga]

well, it doesn't re-trigger auto-assignment...

anyway, per this slack discussion, I'm assigning myself

gonna find someone in #engineering-chat

[aldo-expensify]

I'm trying to verify that this is not already broken in production...

Meanwhile, this is the error:

Apparently we call Validation.filterInput with all values from the form, and that include some boolean values. The function crashes when we pass true to it.

I think the function crashing may be because of this PR:

Expensify/expensify-common#567

cc @Li357

[aldo-expensify]

QA passed:

Screen.Recording.2023-08-23.at.12.23.23.PM.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Only pass strings with a valid number to Str.fromUSDToNumber #25734

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty