[HOLD for payment 2023-09-06] Use idb-keyval in Onyx

[mountiny]

Problem

While investigating performance issues on large accounts we found an issue where storing large amounts of data in onyx takes a very long time (E.g. merging the data from a OpenApp command).
Largely this was due to the underlying storage provider opening a new database transaction for every operation in a multiMerge/multiSet operation.

Solution

The idb-keyval package optimises this, as it can handle multiple operations in one database transaction.
The good thing is, that idb-keyval also uses indexedDB as storage provider, so no migration is needed.

[melvin-bot]

Triggered auto assignment to @maddylewis (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[mountiny]

No design changes required

[hannojg]

👋

[mountiny]

This does not have to be Daily I believe.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Performance: Onyx new storage wrapper (idk-keyval) #25565

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[maddylewis]

just confirming that the only payment due for this one is to @hannojg, correct? is it the standard $500?

[situchan]

@maddylewis I reviewed PR and I am the only one due upwork payment.
@hannojg is from Margelo.

I think this applies to $1000 as PR was reviewed and merged before announcement.

[mountiny]

agreed with @situchan

[maddylewis]

ok got it. thanks for clarifying. let me get that payment processed rn!

[maddylewis]

offer sent

[maddylewis]

paid!