-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD 309451] Rewrite setup-mapbox-sdk.sh
in Node for better cross-platform support
#25442
Comments
I can do the conversion if needed. |
I can help with the review if needed. |
nice! I'll assign you to this issue then 🚀 When your PR is ready, please assign @mananjadhav and me as the reviewers |
@allroundexperts Because I'm re-writing the script to call an endpoint in our backend to obtain a temporary Mapbox token (instead of requiring each contributor to create a Mapbox account and obtain a token), I gonna go ahead and do the re-write in Node/TypeScript here in this PR. I gonna un-assign you because we no longer need a separate PR for this 🙇 I gonna assign you as a reviewer to my PR instead. |
Sounds good @hayata-suenaga. You can assign me as a reviewer there if needed. |
@allroundexperts assigned you here |
setup-mapbox-sdks
and setup-mapbox-sdks-walkthough
in nodesetup-mapbox-sdk.sh
in Node for better cross-platform support
setup-mapbox-sdk.sh
in Node for better cross-platform supportsetup-mapbox-sdk.sh
in Node for better cross-platform support
I'm closing this because this issue is taken care of by this PR. |
Triggered auto assignment to @anmurali ( |
Bug0 Triage Checklist (Main S/O)
|
@anmurali please issue a payment of $250 to @allroundexperts for their review of this PR (although the PR was closed, they reviewed the PR and should get a partial payment) |
$250 payment approved for @allroundexperts based on comment above. |
@allroundexperts, @hayata-suenaga Eep! 4 days overdue now. Issues have feelings too... |
waiting for the payment to be accepted |
We're not doing this for now as there hasn't been issue from contributors on this |
@allroundexperts, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
1 similar comment
@allroundexperts, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@allroundexperts, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick! |
forgot to close this one |
cc: @neil-marcellini
We have bash scripts for configuring the credentials that are needed to download Mapbox SDKs. Rewrite the scripts in node to make them platform agnostic.
The text was updated successfully, but these errors were encountered: