Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 309451] Rewrite setup-mapbox-sdk.sh in Node for better cross-platform support #25442

Closed
hayata-suenaga opened this issue Aug 17, 2023 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Aug 17, 2023

cc: @neil-marcellini

We have bash scripts for configuring the credentials that are needed to download Mapbox SDKs. Rewrite the scripts in node to make them platform agnostic.

@allroundexperts
Copy link
Contributor

I can do the conversion if needed.

@mananjadhav
Copy link
Collaborator

I can help with the review if needed.

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Aug 18, 2023

I can do the conversion if needed.

nice! I'll assign you to this issue then 🚀 When your PR is ready, please assign @mananjadhav and me as the reviewers

@hayata-suenaga hayata-suenaga added Help Wanted Apply this label when an issue is open to proposals by contributors and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 18, 2023
@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Aug 20, 2023

@allroundexperts Because I'm re-writing the script to call an endpoint in our backend to obtain a temporary Mapbox token (instead of requiring each contributor to create a Mapbox account and obtain a token), I gonna go ahead and do the re-write in Node/TypeScript here in this PR.

I gonna un-assign you because we no longer need a separate PR for this 🙇 I gonna assign you as a reviewer to my PR instead.

@allroundexperts
Copy link
Contributor

Sounds good @hayata-suenaga. You can assign me as a reviewer there if needed.

@hayata-suenaga
Copy link
Contributor Author

@allroundexperts assigned you here

@hayata-suenaga hayata-suenaga changed the title Rewrite setup-mapbox-sdks and setup-mapbox-sdks-walkthough in node Rewrite setup-mapbox-sdk.sh in Node for better cross-platform support Aug 20, 2023
@neil-marcellini neil-marcellini changed the title Rewrite setup-mapbox-sdk.sh in Node for better cross-platform support [HOLD 309451] Rewrite setup-mapbox-sdk.sh in Node for better cross-platform support Aug 29, 2023
@hayata-suenaga
Copy link
Contributor Author

I'm closing this because this issue is taken care of by this PR.

@hayata-suenaga hayata-suenaga added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 31, 2023
Copy link

melvin-bot bot commented Oct 31, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Oct 31, 2023
Copy link

melvin-bot bot commented Oct 31, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@hayata-suenaga
Copy link
Contributor Author

@anmurali please issue a payment of $250 to @allroundexperts for their review of this PR (although the PR was closed, they reviewed the PR and should get a partial payment)

@melvin-bot melvin-bot bot added the Overdue label Nov 3, 2023
@JmillsExpensify
Copy link

$250 payment approved for @allroundexperts based on comment above.

Copy link

melvin-bot bot commented Nov 6, 2023

@allroundexperts, @hayata-suenaga Eep! 4 days overdue now. Issues have feelings too...

@hayata-suenaga
Copy link
Contributor Author

waiting for the payment to be accepted

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 6, 2023
@hayata-suenaga
Copy link
Contributor Author

We're not doing this for now as there hasn't been issue from contributors on this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 10, 2023
Copy link

melvin-bot bot commented Nov 13, 2023

@allroundexperts, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
Copy link

melvin-bot bot commented Nov 13, 2023

@allroundexperts, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 13, 2023

@allroundexperts, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor Author

forgot to close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants