Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status - Status reverts to previous status or turns blank when going offline after saving #24423

Closed
2 of 6 tasks
lanitochka17 opened this issue Aug 11, 2023 · 21 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Precondition: Set different status and erase it before running the steps

  1. Launch New Expensify app
  2. Go to Settings > Profile > Status
  3. Add a status and save it
  4. Immediately go offline

Expected Result:

When going offline, the status remains as is

Actual Result:

When going offline, the status either reverts to a previous status (precondition) or it becomes blank

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.53.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6161049_Screen_Recording_20230811_104449_New_Expensify.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 11, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 11, 2023

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@conorpendergrast
Copy link
Contributor

@lanitochka17 I don't think that's the correct video, could you check?

@0xmiros
Copy link
Contributor

0xmiros commented Aug 11, 2023

Custom status bugs are not blockers.
Context: https://expensify.slack.com/archives/C049HHMV9SM/p1691610130667239

@amyevans
Copy link
Contributor

Yeah the attached video isn't correct but I reproed with the test steps. But as @0xmiroslav pointed out (thanks!) this is a feature under active development so we won't consider them blockers. Assigning over to @stitesExpensify to handle in the context of that project!

@amyevans amyevans added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 11, 2023
@amyevans amyevans assigned stitesExpensify and unassigned amyevans Aug 11, 2023
@stitesExpensify
Copy link
Contributor

Thanks @0xmiroslav @amyevans !

@perunt
Copy link
Contributor

perunt commented Aug 12, 2023

Just to be sure that you pressed save button on the Status screen(with money stack logo) as well as on StatusSetPage (where you check emoji with text)
I can't reproduce it
Could you update the video?

@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@lanitochka17
Copy link
Author

Sorry for the confusion. Correct video

Bug6161049_Screen_Recording_20230811_104449_New_Expensify.1.mp4

@stitesExpensify stitesExpensify added Weekly KSv2 and removed Daily KSv2 labels Aug 15, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2023
@stitesExpensify
Copy link
Contributor

Are you still able to reproduce this @lanitochka17 ?

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2023
@lanitochka17
Copy link
Author

Issue is reproducible with new Build 1.3.57-2
Detailed steps for reproduction:

  1. Launch New Expensify app
  2. Go to Settings > Profile > Status
  3. Add a status and save it
  4. Immediately go offline
  5. Go to Contact methods
  6. Return to previous page
  7. Note that the status reverts to previous one or it goes blank
Screen_Recording_20230825_035542_New.Expensify.1.mp4

@perunt
Copy link
Contributor

perunt commented Aug 25, 2023

I'm not being able to reproduce it yet. I've tried CPU and network throttling as well. Is it reproducible each time?
Let me try to do it from the main

telegram-cloud-document-2-5422648708032376152.mp4

UPD: I can't reproduce it on the main either

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@stitesExpensify
Copy link
Contributor

Since @perunt can't reproduce I'm going to close

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@lanitochka17
Copy link
Author

Issue is still reproducible
Steps:

  1. As User A, go offline, set Custom Status 1, then go online
  2. As User B, verify that Custom Status 1 is shown for User A
  3. As User A, clear the custom status and go offline (make sure it is updated on User B end before going offline)
  4. As User A, go offline and set Custom Status 2, then go online
  5. Note that after a while, the custom status is cleared on its own on User A side
  6. As User A, create Custom Status 3
  7. As User B, note that User B sees Custom Status 2 instead of Custom Status 3
20230921-031152_016P9jNd.mp4

@stitesExpensify
Copy link
Contributor

Assigned Taras since this is still reproducible

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2023
@stitesExpensify
Copy link
Contributor

Any updates here?

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@perunt
Copy link
Contributor

perunt commented Oct 23, 2023

@lanitochka17, do you use any throttle tools?
I've tried it with the slow 3g, and even then, it was way faster than your network.
I assume it is related to the request queue. When it fails when you go offline, it can remove optimistic data. But I'm still in the testing process.

clideo_editor_ba738351f42b430895074a5f4b9aaffd.mp4

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2023
@stitesExpensify
Copy link
Contributor

bump @lanitochka17

@melvin-bot melvin-bot bot removed the Overdue label Nov 3, 2023
@lanitochka17
Copy link
Author

@perunt Hello. most likely the issue was reproduced with low Internet traffic
Issue is not reproducible on build 1.3.95-5

0-02-01-b0c5d6408a318113fa4ff47b5b0aacf14cf38a70b58c2659a6106a9a03fdc625_e2e0e34b64fb00dc.mp4

@perunt
Copy link
Contributor

perunt commented Nov 6, 2023

From what I saw, there is a problem with the queue. Also, I remember recently that the queue was changed a bit. So, it's probably related.
Do I get you right? Is it no more reproducible in newer builds?

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2023
@stitesExpensify
Copy link
Contributor

bump @lanitochka17

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
@stitesExpensify
Copy link
Contributor

Closing this for now since we haven't heard anything for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants