[Hold on 306294] Console error while opening child reports

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on FAB -> Assign Task
2. Go to task report
3. Go to parent Report
4. Go to same task task from parent report
5. Observe Console error.
   You can open any IOU report to reproduce this error

Expected Result:

There should be no console error

Actual Result:

There's a console error

Workaround:

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.49-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5786.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nodebrute
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691035111039979

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jfquevedol2198]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error while opening child reports

What is the root cause of that problem?

parentReportID, which is one of props of ParentNavigationSubtitle component is defined as string, but number type is passed.

What changes do you think we should make in order to solve the problem?

App/src/components/ParentNavigationSubtitle.js

Line 21 in 58dc0c9

parentReportID: PropTypes.string,

Update parentReportID type like this:

parentReportID: PropTypes.oneOfType([PropTypes.string, PropTypes.number])

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error while opening child reports

What is the root cause of that problem?

Sometimes, type of props.report.parentReportID is a number.

App/src/pages/home/HeaderView.js

Line 195 in d6a14d7

parentReportID={props.report.parentReportID}

That makes a console error appears because the expected type of parentReportID prop in ParentNavigationSubtitle is string

App/src/components/ParentNavigationSubtitle.js

Line 21 in 58dc0c9

parentReportID: PropTypes.string,

What changes do you think we should make in order to solve the problem?

Change props.report.parentReportID to props.report.parentReportID.toString() to verify that parentReportID prop always is a string

App/src/pages/home/HeaderView.js

Line 195 in d6a14d7

parentReportID={props.report.parentReportID}

What alternative solutions did you explore? (Optional)

[Nodebrute]

@s77rt This is related to https://expensify.slack.com/archives/C01GTK53T8Q/p1691167905181059 parentReportID stored as a number.

[s77rt]

@anmurali This is being handled internally. cc @cristipaval @bondydaa

[cristipaval]

yes this should be held on https://github.com/Expensify/Expensify/issues/306294

[anmurali]

Handled internally and held on https://github.com/Expensify/Expensify/issues/306294

[melvin-bot]

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

Held.

[melvin-bot]

@anmurali this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

Asked in the issue this is held on what our ETA is as the PR appears to have slowed down.

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@anmurali 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[anmurali]

Still held on https://github.com/Expensify/Expensify/issues/306294
Bumped that issue again. Going to change the prioritization of this one to a Weekly since it looks like the held PR is going slowly.

[anmurali]

Making this a monthly as the issues are console issues not related to customer and so are lower priority

[anmurali]

Still held on https://github.com/Expensify/Expensify/issues/306294 - asked for an update

[anmurali]

@cristipaval - https://github.com/Expensify/Expensify/issues/306294 is now closed. Can we take this off hold?

[cristipaval]

@anmurali, it seems that this issue is not reproducible anymore.