Total request money wrong after delete a request

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a chat with a user have chatted together before
2. Click + in compose and create 2 requests money
3. Click request money view
4. Delete one of requests, Observe that total remains the same after being deleted

Expected Result:

Total update after delete a request money

Actual Result:

Total not update after delete a request money

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.51-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

request.mp4

Recording.1452.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691235556837429

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The total amount of money requested does not decrease when canceling other requests and does not show the request total to the assigned user

What is the root cause of that problem?

If cancel the money request, the money request report's total is decreased.
But MoneyReqeustView will not be refreshed, because ReportActionItem does not check if the total field is changed or not.

App/src/pages/home/report/ReportActionItem.js

Lines 601 to 625 in 012d604

	memo(
	ReportActionItem,
	(prevProps, nextProps) =>
	prevProps.displayAsGroup === nextProps.displayAsGroup &&
	prevProps.draftMessage === nextProps.draftMessage &&
	prevProps.isMostRecentIOUReportAction === nextProps.isMostRecentIOUReportAction &&
	prevProps.hasOutstandingIOU === nextProps.hasOutstandingIOU &&
	prevProps.shouldDisplayNewMarker === nextProps.shouldDisplayNewMarker &&
	_.isEqual(prevProps.emojiReactions, nextProps.emojiReactions) &&
	_.isEqual(prevProps.action, nextProps.action) &&
	_.isEqual(prevProps.report.pendingFields, nextProps.report.pendingFields) &&
	_.isEqual(prevProps.report.errorFields, nextProps.report.errorFields) &&
	lodashGet(prevProps.report, 'statusNum') === lodashGet(nextProps.report, 'statusNum') &&
	lodashGet(prevProps.report, 'stateNum') === lodashGet(nextProps.report, 'stateNum') &&
	prevProps.translate === nextProps.translate &&
	// TaskReport's created actions render the TaskView, which updates depending on certain fields in the TaskReport
	ReportUtils.isTaskReport(prevProps.report) === ReportUtils.isTaskReport(nextProps.report) &&
	prevProps.action.actionName === nextProps.action.actionName &&
	prevProps.report.reportName === nextProps.report.reportName &&
	prevProps.report.description === nextProps.report.description &&
	ReportUtils.isCompletedTaskReport(prevProps.report) === ReportUtils.isCompletedTaskReport(nextProps.report) &&
	prevProps.report.managerID === nextProps.report.managerID &&
	prevProps.report.managerEmail === nextProps.report.managerEmail &&
	prevProps.shouldHideThreadDividerLine === nextProps.shouldHideThreadDividerLine,
	),

So the total amount of money request does not decrease.

What changes do you think we should make in order to solve the problem?

We should add checking if report.total is changed or not in ReportActionItem.

    memo(
        ReportActionItem,
        (prevProps, nextProps) =>
            ...
            lodashGet(prevProps.report, 'total', 0) === lodashGet(nextProps.report, 'total', 0),
    ),

What alternative solutions did you explore? (Optional)

None.

[namhihi237]

I think the issue is the same as the issue I reported on slack before here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[srikarparsi]

We can close this out as it's being taken care of in this deploy blocker.

[namhihi237]

@srikarparsi i think i am first reporter so can you update github reporter blocker if we close here

[StevenKKC]

@srikarparsi Should I raise PR in this issue? #24267 is already closed.

[Julesssss]

We can close this out as it's being taken care of in this #24267.

I think it might not be handled still.

[mallenexpensify]

Removing Reviewing so this'll go overdue so we can see if an action is needed.
@Julesssss any current thoughts?

[Julesssss]

I think this is done. The linked PR was closed and I can't reproduce it anymore.