[$1000] Android - App displays broken message text without email for existing email contact on user details

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app on android
2. Open any report
3. Mention email only user to whom you have already chatted before (user email should not have dot in its email before @) and send the message
4. Click on mention to open details page and observe that app does not display email besides 'message' and also paritally cut the message text

Expected Result:

App should display user email beside 'message' on user details page. If the email is too long, it should display similar to this, where ... are on the far right of the screen

Actual Result:

App does not display user email besides message on user details and displays truncated 'message' if we had already chatted with user and user email has no dot before @

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.43-7
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

user.details.message.truncated.no.email.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: GH handle - @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689956338921469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0114172bcac0ccb2df
• Upwork Job ID: 1686155247894810624
• Last Price Increase: 2023-07-31

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

Was able to repro, updated the Expected behavior with

App should display user email beside 'message' on user details page. If the email is too long, it should display similar to this, where ... are on the far right of the screen

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0114172bcac0ccb2df

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - App displays broken message text without email for existing email contact on user details

What is the root cause of that problem?

We're missing style for the menu item message here

App/src/pages/DetailsPage.js

Lines 205 to 211 in 6eb03b0

	<MenuItem
	title={`${props.translate('common.message')}${details.displayName}`}
	icon={Expensicons.ChatBubble}
	onPress={() => Report.navigateToAndOpenReport([login])}
	wrapperStyle={styles.breakAll}
	shouldShowRightIcon
	/>

We need to specific how much space the title style should take

What changes do you think we should make in order to solve the problem?

We can add styles.w100 or styles.flex1 into props titleStyle of component MenuItem in those LOC

Result:

[thesahindia]

@hoangzinh, your solution didn't work for me. Can you test your solution again?

[hoangzinh]

@thesahindia It's weird. It works well on my end

Screen.Recording.2023-08-02.at.06.05.07.mp4

[melvin-bot]

@mallenexpensify, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mallenexpensify, @thesahindia Still overdue 6 days?! Let's take care of this!

[SosenWiosen]

I think this might be a duplication of #23769. Wasn't able to reproduce on the latest main - I think it was repaired in this PR #24142 . Will check if it occurs for me in earlier code.

[dhanashree-sawant]

Hi @SosenWiosen, @thesahindia, the issue is raised before #23769, if it was solved because of that issue, will it be eligible for reporting bonus?

[melvin-bot]

@mallenexpensify @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@mallenexpensify, @thesahindia Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[thesahindia]

Hi @SosenWiosen, @thesahindia, the issue is raised before #23769, if it was solved because of that issue, will it be eligible for reporting bonus?

cc: @mallenexpensify

[mallenexpensify]

Sorry for the lonnnnng delay, I was caught up in a deadline for another project.

#23769
Created on July 27th

This bug reported created on July 21

@dhanashree-sawant , it appears they are the same or similar, is there any way to 'prove' that the PR for that one fixed this? Asking cuz it's helpful to have a link to drop in for auditing purposes if I pay this out for the reporting bonus.

[dhanashree-sawant]

From what I have seen in the PR and in that issue, root cause was 'The root cause is android use different way to break words' (taken from this proposal) and changes was made on both details and profile page. In this issue, we had the same root cause for 'Message' text truncate on details page. Since that PR also made the changes on Details page too, the following issue seems to be fixed due that.

[melvin-bot]

@mallenexpensify @thesahindia this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@mallenexpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Thanks @dhanashree-sawant , it seems/sounds like, since you reported the issue first, you are due compensation for reporting the bug. (and, the other contributor was already compensated cuz that bug got fixed first so we can't/won't claw that payment back). Can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0114172bcac0ccb2df

[dhanashree-sawant]

Thanks @mallenexpensify, I have accepted the offer.

[melvin-bot]

@mallenexpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Issue reporter: @dhanashree-sawant paid $250 via Upwork