Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Bank Account - Unable to enter year of birth from keyboard on Personal Information page #23576

Closed
2 of 6 tasks
kbecciv opened this issue Jul 25, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jul 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open Desktop App or go to staging.new.expensify.com on Chrome
  2. Login with expensifail account
  3. Go to existing or create new workspace
  4. Go to Workspace > Connect Bank Account > Connect with plaid and follow the flow to the Personal Information page
  5. Enter the date of birth using keyboard

Expected Result:

User can enter date of birth using keyboard

Actual Result:

Unable to enter YEAR of birth from keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.45.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6141271_BA-_Personal-Info-DoB-Keys-Year.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 25, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

  • Confirmed broken on staging.
  • Looking for offending PR.

@marcaaron
Copy link
Contributor

@srikarparsi @marcochavezf looks like this one -> #20864

@marcaaron marcaaron removed their assignment Jul 25, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jul 25, 2023
@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Jul 26, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 26, 2023
@melvin-bot melvin-bot bot changed the title Bank Account - Unable to enter year of birth from keyboard on Personal Information page [HOLD for payment 2023-08-02] Bank Account - Unable to enter year of birth from keyboard on Personal Information page Jul 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 27, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-08-02] Bank Account - Unable to enter year of birth from keyboard on Personal Information page [HOLD for payment 2023-08-03] [HOLD for payment 2023-08-02] Bank Account - Unable to enter year of birth from keyboard on Personal Information page Jul 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 4, 2023

@srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@srikarparsi
Copy link
Contributor

No payment needed for this issue as it was reported by applause and resolved internally.

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2023
@srikarparsi srikarparsi reopened this Aug 8, 2023
@srikarparsi
Copy link
Contributor

Actually, @allroundexperts were you paid for testing the PR?

@allroundexperts
Copy link
Contributor

I don't think so @srikarparsi

@srikarparsi
Copy link
Contributor

Cool! Can you please raise a manual request whenever you get a chance?

@allroundexperts
Copy link
Contributor

Sure, requested.

@melvin-bot melvin-bot bot added the Overdue label Aug 10, 2023
@srikarparsi
Copy link
Contributor

srikarparsi commented Aug 10, 2023

Closing this out but please reopen if payment isn't received.

@melvin-bot melvin-bot bot removed the Overdue label Aug 10, 2023
@JmillsExpensify
Copy link

@srikarparsi Can you confirm in writing that @allroundexperts should be compensated $1,000 for this PR review?

@srikarparsi
Copy link
Contributor

Hi! Yes, @allroundexperts should be compensated $1,000 for reviewing this PR.

@JmillsExpensify
Copy link

Thanks for confirming! Approved for payment in NewDot.

@JmillsExpensify
Copy link

Actually this is a component refactor and may only be eligible for $250. Asking internally first.

@srikarparsi
Copy link
Contributor

srikarparsi commented Aug 15, 2023

Just confirmed that this should be $250 for reviewing a revert to a refactor functional component PR. Sorry for the confusion @allroundexperts.

@JmillsExpensify
Copy link

Thank you! I'll update the request in NewDot and get this processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants