Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS - Keyboard covers the main composer when going to the thread and coming back #23423

Closed
1 of 6 tasks
kbecciv opened this issue Jul 23, 2023 · 7 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Jul 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Log in with any account and go to any chat
  2. Send any message and select reply in thread
  3. Back to the main chat by clicking back button in the header
  4. Set focus the main composer

Expected Result:

Keyboard doesn't cover the main composer

Actual Result:

Keyboard covers the main composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.43-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

keyboard_navigation.mp4
RPReplay_Final1690132266.MP4

Expensify/Expensify Issue URL:
Issue reported by: @s-alves10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689948179939349

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 23, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 23, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@dummy-1111
Copy link
Contributor

dummy-1111 commented Jul 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard covers the composer when going into the thread and coming back

What is the root cause of that problem?

This is from the PR

We enable the keyboardavoidingview here

const isTopMostReportId = Navigation.getTopmostReportId() === getReportID(this.props.route);

When going into the thread, isTopMostReportId is set to false for the main report, and when navigating back to the main report, it isn't re-rendered because we have removed navigation props in this PR. So when backing to the main report, keyboardavoidingview isn't enabled

This is the root cause

What changes do you think we should make in order to solve the problem?

We should re-render the page when navigating back. We can do this by adding withNavigationFocus to the ReportScreen

This works as expected.

What alternative solutions did you explore? (Optional)

@isabelastisser isabelastisser added the Needs Reproduction Reproducible steps needed label Jul 25, 2023
@isabelastisser
Copy link
Contributor

I can't reproduce this on iOS. Closing!

@dummy-1111
Copy link
Contributor

@isabelastisser

This is still reproducible on ios native. I think we should reopen this issue

@dummy-1111
Copy link
Contributor

dummy-1111 commented Jul 31, 2023

@isabelastisser

This is still reproducible. Please check. I think this is a critical issue

Reproduction
23423.mp4

@dummy-1111
Copy link
Contributor

@isabelastisser

This is still reproducib;e. Let's reopen this
Please refer #24555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

3 participants