Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-09-08] Use current location waypoint editor button #22707

Closed
neil-marcellini opened this issue Jul 11, 2023 · 15 comments
Closed
Assignees

Comments

@neil-marcellini
Copy link
Contributor

Please follow the plan in the design doc.

@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@neil-marcellini neil-marcellini added Weekly KSv2 and removed Daily KSv2 labels Jul 20, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 20, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@hayata-suenaga hayata-suenaga self-assigned this Aug 21, 2023
@hayata-suenaga
Copy link
Contributor

assigning myself to this issue and labeling the issue back to weekly

@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed Monthly KSv2 labels Aug 21, 2023
@tgolen tgolen changed the title [HOLD 22705, Expensify 299204] Use current location waypoint editor button [Expensify 299204] Use current location waypoint editor button Aug 23, 2023
@tgolen tgolen changed the title [Expensify 299204] Use current location waypoint editor button Use current location waypoint editor button Aug 23, 2023
@tgolen tgolen added Daily KSv2 and removed Weekly KSv2 labels Aug 23, 2023
@tgolen
Copy link
Contributor

tgolen commented Aug 23, 2023

This is off hold and I'm bumping up to daily

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Aug 24, 2023

Created an App issue for this: #25855 and asked if CallStack has the availability to help: https://expensify.slack.com/archives/C03UK30EA1Z/p1692887629432809

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor

Linked PRs to this issue ⬆️

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

@hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@hayata-suenaga
Copy link
Contributor

The location PR has been reverted and the original contributor that made the PR is working on the second PR that includes fixes for all regressions.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 labels Sep 1, 2023
@melvin-bot melvin-bot bot changed the title Use current location waypoint editor button [HOLD for payment 2023-09-08] Use current location waypoint editor button Sep 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Sep 2, 2023
@neil-marcellini neil-marcellini changed the title [HOLD for payment 2023-09-08] Use current location waypoint editor button [HOLD SBE][HOLD for payment 2023-09-08] Use current location waypoint editor button Sep 4, 2023
@hayata-suenaga hayata-suenaga changed the title [HOLD SBE][HOLD for payment 2023-09-08] Use current location waypoint editor button [HOLD for payment 2023-09-08] Use current location waypoint editor button Sep 11, 2023
@hayata-suenaga hayata-suenaga removed Reviewing Has a PR in review Awaiting Payment Auto-added when associated PR is deployed to production labels Sep 11, 2023
@hayata-suenaga
Copy link
Contributor

Closing this issue because this is a dupe of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants