[HOLD for pull/21553] Web - Error message overlapping in case of long task description, description display has wrong css

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a task
2. Write long multiline description
3. Click next to go to assignee screen

Expected Result:

Description should be rendered correctly with a fixed height

Actual Result:

No proper css to description box, error message overlaps with below elements

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-06-25.14-39-55-139.1.mp4

Recording.922.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687684353033949

View all open jobs on GitHub

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

error message overlapping in case of long task description, description display has wrong css

What is the root cause of that problem?

We allow multiline for description field in assign task, but we don't add a style to define the max height of description field in NewTaskPage

App/src/pages/tasks/NewTaskPage.js

Lines 161 to 166 in 64b720c

	<MenuItemWithTopDescription
	description={props.translate('newTaskPage.description')}
	title={props.task.description || ''}
	onPress={() => Navigation.navigate(ROUTES.NEW_TASK_DESCRIPTION)}
	shouldShowRightIcon
	/>

What changes do you think we should make in order to solve the problem?

We should add wrapperStyle={[styles.autoGrowHeightMultilineInput, styles.overflowHidden]} to set the max height of description field and hide the overflow text.

App/src/pages/tasks/NewTaskPage.js

Lines 161 to 166 in 64b720c

	<MenuItemWithTopDescription
	description={props.translate('newTaskPage.description')}
	title={props.task.description || ''}
	onPress={() => Navigation.navigate(ROUTES.NEW_TASK_DESCRIPTION)}
	shouldShowRightIcon
	/>

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.26-06-2023.16.53.55.webm

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[chiragxarora]

Might get fixed in #21553

[bfitzexpensify]

Yep, gonna put this as a HOLD for #21553, and once that is deployed to staging I'll test this to see if it is still an issue.

[bfitzexpensify]

Still held

[bfitzexpensify]

Still held on #21553

[bfitzexpensify]

Still held

[bfitzexpensify]

#21553 is now merged. Tested on staging and the solution in #21553 (to limit the description input to 2 lines) means this is no longer a problem. Going to close this out.

[chiragxarora]

am I eligible for reporting bonus for this @bfitzexpensify ?

[bfitzexpensify]

Hey @chiragxarora - #21347 was reported earlier and even though the specific call out was different, the problem was still the same, so this isn't eligible for the reporting bonus.

[chiragxarora]

Okay thanks