[$1000] "Members" item doesn't appear in thread details without refreshing the page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to a chat
2. Send a message
3. Hover over it and create a thread
4. Click on chat header
5. Check that "Members" item is not present
6. Reload the page and check again

Expected Result:

You should see the "Members" item without refreshing the page

Actual Result:

"Members" item doesn't appear without refreshing the page. In production it appears then disappears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5166.mp4

Screen.Recording.2023-06-21.at.2.50.56.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687339647252079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01426c99239721a0e1
• Upwork Job ID: 1673433552396025856
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

Ah yeah, interesting. I wonder if this has something to do with the secure logins refactor project or public rooms as we check to see if you have permission to view the members list. What's interesting though is that it's fine in the #announce room itself (shows immediately), just not the details of the threadReport.

Moving it on!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01426c99239721a0e1

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[bernhardoj]

This is a BE issue. When we create the thread, it will do an OpenReport request to the BE and BE will return empty participantAccountIDs

It works fine if we create the thread while offline.

[melvin-bot]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[trjExpensify]

Cool, thanks! Moving internal.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[s77rt]

@srikarparsi The BE seems to return 2 onyx objects for everything (include the report) which is strange. The first report object contains the participants but the second contains an empty array which overwrites the first.

[srikarparsi]

Thanks @s77rt! Seeing the same duplicate data in the response. Will take a look at this on Friday as I'll mostly be OOO tomorrow.

[trjExpensify]

@srikarparsi did you take a look on Friday?

[srikarparsi]

Hey @trjExpensify! I didn't get a chance Friday and was mostly OOO yesterday and day before for the 4th but will prioritize this today :)

[srikarparsi]

Update: Working on it but running into an issue where the response of the first OpenReport for a new thread is empty. Also unable to post a message to the newly created thread. Not sure if a new PR broke threads on dev or something is wrong locally but will look into it more tomorrow.

[techievivek]

This seems really tricky particularly considering that it's a fundamental aspect of how we provide responses to users. I have started a discussion in the #eng-channnel to figure out a solution that would work https://expensify.slack.com/archives/C03TQ48KC/p1693314354987449

[trjExpensify]

Thanks for the update, @techievivek!

[trjExpensify]

👋 @techievivek did you take that last action to test?

[techievivek]

Sorry, I was ooo last week. Taking a look at it today as we have a potential solution now.

[melvin-bot]

@trjExpensify, @s77rt, @techievivek, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@trjExpensify, @s77rt, @techievivek, @srikarparsi 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[trjExpensify]

@techievivek mind providing a quick update, please?

[techievivek]

Sorry, I have put the PR on HOLD and caught up with @neil-marcellini yesterday to discuss the solution in detail as he has some context around the changes. The code in openReport is extremely tricky especially in terms of participants because we handle them differently. I am working on updating the PR after the discussions but integration tests are failing. I will give it another look by the EOW as I have to focus on other stuff as well.

[techievivek]

Ok, figured out the reason tests were failing and have fixed it, it's ready for a review https://github.com/Expensify/Web-Expensify/pull/38851#issuecomment-1735183083

[srikarparsi]

Unassigning myself from this since @techievivek is working on it

[melvin-bot]

@trjExpensify, @s77rt, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

What's the dealio here? Linked PR is on staging, so we're just waiting for a prod deploy to proceed?

[techievivek]

Yes, QA is over for the staging changes so this should be on PROD today 🤞

[trjExpensify]

Cool, it hit prod an hour ago. Confirming that's the only PR for this issue is it? If so, we can just go forward and pay out the bug report now.

[melvin-bot]

@trjExpensify, @s77rt, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Bump, @techievivek. Can you confirm we're good to pay @Puneet-here $250 for the bug report?

[techievivek]

Yes, this was deployed to PROD: https://github.com/Expensify/Web-Expensify/pull/38851#issuecomment-1753346389 so we can pay the reporting bonus here, thanks.

[trjExpensify]

Cool, sent an offer @Puneet-here!

[Puneet-here]

Accepted the offer.

[trjExpensify]

Paid!