Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin also appears in the "invite new members list in workspace #21037

Closed
6 tasks done
kavimuru opened this issue Jun 19, 2023 · 20 comments
Closed
6 tasks done

Admin also appears in the "invite new members list in workspace #21037

kavimuru opened this issue Jun 19, 2023 · 20 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Jun 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. create new account
  2. create new workspace
  3. go to Settings > Workspace > Members
  4. you can find yourself as member in list
  5. click on invite button

Expected Result:

user should not appears in invite list ifr part of workspace

Actual Result:

user itself appears in invite list

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-17.at.1.52.21.PM.mov
Screenshot (370)

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686990342042729

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru kavimuru changed the title user appears in invite list even after part of workspace Admin also appears in the "invite new members list in workspace Jun 19, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jun 19, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Julesssss
Copy link
Contributor

Julesssss commented Jun 19, 2023

@kavimuru is this only occurring on web, or was that the only platform tested? Also was this tested on production?

@Julesssss
Copy link
Contributor

Julesssss commented Jun 19, 2023

I'm not able to reproduce this... Can you @zanyrenney?

My user is not showing in search.
I am signed in as [email protected]
Screenshot 2023-06-19 at 15 38 39

@Julesssss
Copy link
Contributor

Reducing priority

@Julesssss Julesssss added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jun 19, 2023
@gadhiyamanan
Copy link
Contributor

@Julesssss please try with new account

@Julesssss
Copy link
Contributor

Julesssss commented Jun 19, 2023

THis is a new account. I created the user, created the workspace, and immediately opened the member page. Anyway, I'll leave the issue open while we attempt to reproduce.

@gadhiyamanan
Copy link
Contributor

THis is a new account. I created the user, created the workspace, and immediately opened the member page. Anyway, I'll leave the issue open while we attempt to reproduce.

@Julesssss if it is new account why it shows number of users in list

@Pujan92
Copy link
Contributor

Pujan92 commented Jun 19, 2023

I am not able to reproduce in dev.

@hungvu193
Copy link
Contributor

I'm also not able to reproduce

@Julesssss
Copy link
Contributor

@Julesssss if it is new account why it shows number of users in list

The domain already existed in OldDot. I'm not sure how I can verifiy a new user on staging that isn't associated with an email I control.

@kavimuru
Copy link
Author

kavimuru commented Jun 19, 2023

@Julesssss I tested in public domain account.

@Julesssss
Copy link
Contributor

Sorry, I meant did Applause test all of the platforms? Or just web? Also, was this tested on production or just staging? I'm asking because it helps us to determine whether it should be a blocker.

@kavimuru
Copy link
Author

@Julesssss It is not reproducible in production. It is reproducible in all platforms in staging.

@Julesssss
Copy link
Contributor

Ah thanks. We should update the checkboxes in that case

@Julesssss
Copy link
Contributor

@zanyrenney are you able to reproduce this? So far only Applause can, so maybe this was fixed elsewhere?

@zanyrenney
Copy link
Contributor

No, I am not able to reproduce either:
2023-06-20_18-01-40

I am on staging v1.3.29-8 so this isn't correct:

It is reproducible in all platforms in staging.

@zanyrenney
Copy link
Contributor

chatted with @Julesssss in DM to confirm, we should close this as its not happening anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants