App displays "Hidden" instead of email for group members

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click the plus sign.
2. Click "New group".
3. Add members using random emails.
4. Click on a member's profile and observe that the details pop up to the left. Note that instead of the email, the word "Hidden" is displayed.

Expected Result:

The email of the group member should be displayed.

Actual Result:

The word "Hidden" is displayed instead of the email for group members in newly created groups.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture (18).webm

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687111889634979

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[PauloGasparSv]

Taking a look at this in a bit

[PauloGasparSv]

Taking a look right now!

[PauloGasparSv]

Replicated it locally, seems to happen to users that we don't have a current active chat with (in other words, users that don't have info loaded by the LNH)

[PauloGasparSv]

Btw pretty interestingly but makes total sense: Refreshing the page or signing off then back in doesn't fix this which means both OpenApp and AppInit don't load this info.

I guess the participants page should load this

[PauloGasparSv]

I think this might have been introduced in #20473 since the faulty line was changed/added there. Not 100% sure because that P.R. is pretty huge haha

[PauloGasparSv]

Looks like there is a missing login property that is used there.

I compared the App changes and that login always came from the personalDetails list passed to getAllParticipants, I think I just need to understand why that property is missing.

[PauloGasparSv]

Yup, I think that's the case.

@Beamanator can you give me a hand on this since you worked on this logic? I think the login property is missing in the personalDetails of the report's participants (when openReport is called it doesn't really return that).

I'm not sure if I should:

1. Add the login field in the API around here
2. Coalesce userLogin to userPersonalDetail.displayName like this around here:

   - const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || 'Hidden';
   + const userLogin = Str.removeSMSDomain(userPersonalDetail.login || userPersonalDetail.displayName || '') || 'Hidden';

[PauloGasparSv]

Discussed this bug in this thread a little further and turns out this problem is already known and is caused by isKnownUser as we do return the login if that is truthy.

Instead of implementing one of those solutions let's close this as its NAB + this will be fixed in https://github.com/Expensify/Expensify/issues/292707

[PauloGasparSv]

Oh @kevinksullivan I closed this but I'm not sure if this needs compensation to who found the bug.

[kevinksullivan]

checking this in bug zero