Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is able to request an IOU from Concierge #20991

Closed
1 of 6 tasks
kavimuru opened this issue Jun 18, 2023 · 18 comments
Closed
1 of 6 tasks

User is able to request an IOU from Concierge #20991

kavimuru opened this issue Jun 18, 2023 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Jun 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Sign up with a new account
  2. Click on 'Request money' link
  3. Enter amount & Click on 'Next' button
  4. Select 'Concierge' from the contacts section
  5. Click on 'Request' button

Expected Result:

Concierge shouldn't be listed on the contacts section of an IOU flow

Actual Result:

Concierge is listed on the contacts section of an IOU flow

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-06-18.18-01-12.mp4
Screenshot (370)

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687100910635549

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 18, 2023

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 18, 2023

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Jun 18, 2023
@Natnael-Guchima
Copy link

On the video is a list of places where Concierge starts to appear after the latest staging release.

Screencast.from.2023-06-18.21-31-32.webm

@Pujan92
Copy link
Contributor

Pujan92 commented Jun 19, 2023

@Natnael-Guchima Is it only for new accounts bcoz I am not able to reproduce it?

@Natnael-Guchima
Copy link

Natnael-Guchima commented Jun 19, 2023

@Pujan92 I think it is only reproducible for new accounts with no prior chat history It should be reproducible on existing accounts.

@Pujan92
Copy link
Contributor

Pujan92 commented Jun 19, 2023

Ok, somehow not able to reproduce in dev.

@neil-marcellini
Copy link
Contributor

I'm only able to reproduce with a brand new account. I'll add that to the steps in the description.

@tjferriss
Copy link
Contributor

I'm able to reproduce the issue using a brand new account.

Screenshot 2023-06-19 at 12 43 28

@luacmartins
Copy link
Contributor

More context here. This Auth PR seems to fix the issue. I'll remove the blocker label and put this issue on hold for the Auth deploy. Once we deploy, we should confirm this is fixed on staging.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Jun 19, 2023
@luacmartins luacmartins changed the title User is able to request an IOU from Concierge [Hold Auth #8141] User is able to request an IOU from Concierge Jun 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2023
@tjferriss
Copy link
Contributor

It looks like the Auth PR has been deployed. Can we take this off hold?

@melvin-bot melvin-bot bot removed the Overdue label Jun 22, 2023
@neil-marcellini
Copy link
Contributor

Yep! @tjferriss would you please see if this is fixed on staging?

@neil-marcellini neil-marcellini changed the title [Hold Auth #8141] User is able to request an IOU from Concierge User is able to request an IOU from Concierge Jun 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 26, 2023
@neil-marcellini
Copy link
Contributor

Gentle bump @tjferriss

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2023
@Natnael-Guchima
Copy link

This seems to be fixed on the latest release.

@neil-marcellini
Copy link
Contributor

Great, thanks you, closing this. No reporting bonus is needed since applause reported it.

@Natnael-Guchima
Copy link

@neil-marcellini I am the one who reported this issue. You can find my name on the 'issue reported by' section.

@neil-marcellini
Copy link
Contributor

I responded on Slack here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants