[HOLD for payment 2023-07-06] [HOLD for payment 2023-07-05] Removing CP Staging label

[luacmartins]

Problem

Coming from this thread and in the spirit of discussing the necessity of each CP, we decided to remove the CP Staging label so that NewDot CPs can only be manually CPed by App deployers after a discussion about the real need for that CP.

Why is this important

Ensures that we always discuss each CP by making authors request the CP in Slack.

Solution

Remove CP Staging label and its functionality

cc @Expensify/mobile-deployers

[melvin-bot]

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[AndrewGable]

I can implement this

[johncschuster]

Am I needed on this one?

[roryabraham]

This will be internal so you're probably good here @johncschuster

[roryabraham]

Let's plz try to get #20791 over the finish line before we start implementation on this.

[AndrewGable]

Held on #20791

[roryabraham]

I think we can take this off HOLD now

[AndrewGable]

Removed label, I will remove the code now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA]Remove CP Staging label functionality #21601

If no regressions arise, payment will be issued on 2023-07-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[thienlnam]

Closing - no payments here to send out here!

There is one linked issue I opened up here: #21763 about the CP process but the CP Staging label is no more!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA]Remove CP Staging label functionality #21601

If no regressions arise, payment will be issued on 2023-07-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty