[$1000] Web - Settings - After pressing the Esc key, Help tab is highlighted with a blue frame

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings
4. Right click on Help to open 'copy URL to clipboard'
5. Press the ESC key

Expected Result:

Help tab is NOT highlighted with a blue frame

Actual Result:

Help tab is highlighted with a blue frame

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.15-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Found wen executing #18982

Bug6058919_Recording__4570.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0129115da114303785
• Upwork Job ID: 1659645561957105664
• Last Price Increase: 2023-05-19

[melvin-bot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On the web, go to settings and right click on Help to open modal copy URL to clipboard then press ESC, help tab will be highlighted with a blue frame.

What is the root cause of that problem?

When pressing Esc after open model copy this MenuItem gets focused and the blue outlines are shown by using the :focus-visible CSS styling.

  :focus-visible {
     outline: 0;
     box-shadow: inset 0px 0px 0px 1px #5AB0FF;
  }

What changes do you think we should make in order to solve the problem?

Remove focus styles in PressableWithSecondaryInteraction component by adding already styles styles.noOutline when MenuItem has prop shouldBlockSelection == true

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-05-18.at.17.32.32.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0129115da114303785

[melvin-bot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

[thienlnam]

https://expensify.slack.com/archives/C01GTK53T8Q/p1683536291949379
Actually, we've decided to do nothing for these issues