[HOLD for payment 2023-06-02] [$1000] On task title editing page when title field is empty than error message is This field is required instead of please enter a title

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app -> Login in account
2. Click on FAB button -> Click on Assign task option
3. Enter title -> Assign task -> Click on confirm task -> will navigate to task detail page
4. On task detail page click on Task (name) -> clear title field and press save -> Notice error message is This field is required instead of please enter a title

Expected Result:

On task title editing page error message should be please enter a title when empty

Actual Result:

On task title editing page error message is This field is required which is not inconsistent to other pages of task

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.9
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684138217007209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01af6e96d10c81b9cb
• Upwork Job ID: 1660741242395484160
• Last Price Increase: 2023-05-22

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kavimuru]

Proposal

by
@Dhairya Senjaliya

Please re-state the problem that we are trying to solve in this issue.

• On task title editing page when title field is empty than error message is This field is required instead of please enter a title

What is the root cause of that problem?

The reason is we are using general form error common.error.fieldRequired

What changes do you think we should make in order to solve the problem?

We have already defined an error message if task name is empty which is newTaskPage.pleaseEnterTaskName
We just need to replace old message with new one on validate() inside the TaskTitlePage.js

      if (_.isEmpty(values.title)) {
-        errors.title = props.translate('common.error.fieldRequired');
+        errors.title = props.translate('newTaskPage.pleaseEnterTaskName');
      }

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

@sophiepintoraetz - I've run out of time to continue looking into this one. I'm OOO until Wednesday, May 24, and following the new process. I'm reassigning the Bug label to identify if this is a bug and continue the process to avoid stalling it. Thank you!

[sophiepintoraetz]

Ah, I needed to confirm the task by sharing first - I am able to reproduce

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[sophiepintoraetz]

@greg-schroeder - in case there's any movement on the issue between Al coming back in office on Wed - assigning you in case something happens!

[flodnv]

I personally much prefer specific error messages than seeing This field is required everywhere. Let's go with the original first proposal then.

[dhairyasenjaliya]

agree since we already have customized messages no reason to stick to default messages @flodnv

[luacmartins]

Makes sense. Let's do it!

[dhairyasenjaliya]

PR updated @flodnv

[alexpensify]

@greg-schroeder and @sophiepintoraetz - I appreciate your help here! I'm back online and removing your assignment.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.18-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix inconsistency in title error message #19429

If no regressions arise, payment will be issued on 2023-06-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@eVoloshchak - When you get a chance, please fill out the checklist above. Thanks!

[alexpensify]

@eVoloshchak and @dhairyasenjaliya - To prepare for the payment date, please apply to the job in Upwork:

https://www.upwork.com/jobs/~01af6e96d10c81b9cb

Thanks!

[alexpensify]

@eVoloshchak - When you get a chance, please apply for the job in Upwork so I'm ready for the payment date on June 2. Thanks!

[alexpensify]

We are on track for payment tomorrow. I don't see an Urgency Bonus here but I did notice that @dhairyasenjaliya reported the bug and fixed it, so I will include that in the payment process.

[dhairyasenjaliya]

@alexpensify I believe this should be eligible for urgency bonus since PR was created within same day but after that we were discussing the right message it took some time to decide and changes were done back and forth so for that and for that reason it got bit delay

[eVoloshchak]

Will finish-up the checklist today

[alexpensify]

@dhairyasenjaliya - Thank you for flagging the concerns here, it looks like the automation missed the notice. I went back to manually audited the project and I see the assignment was on May 22. The PR was merged on May 24, so I will factor in the urgency bonus when I work on the payment process later today.

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Tasks Detailed View #17940

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17940/files#r1214579816

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Don't think an additional discussion is needed here, this was just the wrong text used

• Determine if we should create a regression test for this bug. A very minor bug with extremely low impact. Regression test isn't needed here

[alexpensify]

@eVoloshchak and @dhairyasenjaliya - the payments have been prepared in Upwork. Please accept and I can complete the process.

[dhairyasenjaliya]

done @alexpensify

[alexpensify]

@eVoloshchak and @dhairyasenjaliya - everyone has been paid in Upwork. I'll wait to confirm again on Monday, then will close the GH.

[alexpensify]

I'm closing this GH and the job in Upwork. Great work here!