Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error appears when pressing enter by not selecting suggested mention #19012

Closed
1 of 6 tasks
kavimuru opened this issue May 16, 2023 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open any chat
  2. type @ and an email to get only one item on the suggestion list
  3. Press the down key on your keyboard to deselect the item from the list
  4. Press Enter

Expected Result

No error appears on the console

Actual Result

Uncaught TypeError: Cannot read properties of undefined (reading 'alternateText') Error appears on the console

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.14.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-15.at.10.29.08.PM.mov
4

Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684179183137189

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

cc @getusha @perunt

@perunt
Copy link
Contributor

perunt commented May 16, 2023

thanks for creating the issue, let see if @getusha will confirm the bug

@getusha
Copy link
Contributor

getusha commented May 16, 2023

The issue is not reproducible on that PR but the change

this.props.onFocusedIndexChanged(0);

is not fixing the issue removed it and still the same.

@sophiepintoraetz
Copy link
Contributor

I'm not able to produce this bug on staging - despite pressing the down arrow, it's not deselecting.

2023-05-17_10-33-55 (1)

@sophiepintoraetz
Copy link
Contributor

Raised here but I don't think this can be reliably reproduced.

@sophiepintoraetz sophiepintoraetz added the Needs Reproduction Reproducible steps needed label May 17, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label May 17, 2023
@sophiepintoraetz
Copy link
Contributor

Okay, closing this one out - we can reopen if we are able to reproduce/it resurfaces.

@getusha
Copy link
Contributor

getusha commented May 18, 2023

Am i eligible for reporting bonus?

@mountiny
Copy link
Contributor

@getusha usually if the bug was not reproducible and we havent fixed it intentionally then we dont pay for reporting.

@getusha
Copy link
Contributor

getusha commented May 19, 2023

@mountiny
Just commented here because i've seen some similar instances like this one #18217 (comment)

@mountiny
Copy link
Contributor

Its case by case for sure, in this case we had lots of features quickly rolling out and some of the bugs had fixes up as the issues were reported as we knew about them. So its a thin line for sure but in general we pay out for a bug if the report has been what sparked the solution. In this case, the bug just disappeared with some change so even if you wouldnt report it, it would get fixed if that makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants