Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS builds by resetting the min supported iOS version #18776

Closed
Julesssss opened this issue May 11, 2023 · 7 comments
Closed

Fix iOS builds by resetting the min supported iOS version #18776

Julesssss opened this issue May 11, 2023 · 7 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@Julesssss
Copy link
Contributor

Julesssss commented May 11, 2023

Problem

  • The default iOS min-supported version has changed with a recent R.N version bump
  • We have libraries that depend on a higher version than the default
  • We cannot currently generate CI builds!
  • This also unblocks this issue

Solution

This

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0169d336ee73ea1b53
  • Upwork Job ID: 1656675681736626176
  • Last Price Increase: 2023-05-11
@Julesssss Julesssss added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels May 11, 2023
@Julesssss Julesssss self-assigned this May 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0169d336ee73ea1b53

@Julesssss Julesssss added the Reviewing Has a PR in review label May 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

@Julesssss
Copy link
Contributor Author

This needs to be tested internally due to Apple

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 15, 2023
@melvin-bot melvin-bot bot changed the title Fix iOS builds by resetting the min supported iOS version [HOLD for payment 2023-05-22] Fix iOS builds by resetting the min supported iOS version May 15, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 16, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-22] Fix iOS builds by resetting the min supported iOS version [HOLD for payment 2023-05-23] [HOLD for payment 2023-05-22] Fix iOS builds by resetting the min supported iOS version May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 21, 2023
@Julesssss Julesssss changed the title [HOLD for payment 2023-05-23] [HOLD for payment 2023-05-22] Fix iOS builds by resetting the min supported iOS version [HOLD for payment 2023-05-23] Fix iOS builds by resetting the min supported iOS version May 24, 2023
@Julesssss
Copy link
Contributor Author

Completed!

@melvin-bot melvin-bot bot removed the Overdue label May 24, 2023
@Julesssss Julesssss changed the title [HOLD for payment 2023-05-23] Fix iOS builds by resetting the min supported iOS version Fix iOS builds by resetting the min supported iOS version May 24, 2023
@Julesssss Julesssss removed the Awaiting Payment Auto-added when associated PR is deployed to production label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

2 participants