Unable to request money after settling existing ious

[Julesssss]

cc @mountiny @luacmartins

Problem

Some IOURequests are failing. This is a new regression.

You need to settle a few requests before the bug occurs. It might also be related to workspaces. In my case it is happenening to the workspace admin.

• As userA, Request money
• As userB, pay it
• As userB, Request money
• As userA, pay it
• As userA, request money
• At some point we start. reusing the iouReportID which is a major regression. Theory is listed below

This appears to be occurring because we no longer clear the chatReport.iouReportID property when an IOU is paid. Because of this, this line is reusing an iouReportID instead of generating a new one optimistically.

Solution

Figure out why we aren't clearing the iouReport.iouReportID, or update the mentioned logic so that we don't pass OLD iouReportIDs to the requestMoney API.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013b510aa28fd9747e
• Upwork Job ID: 1656328070402617344
• Last Price Increase: 2023-05-10

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013b510aa28fd9747e

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[Julesssss]

This might be related to missing optimistic data being persisted to Onyx.

[trjExpensify]

Asked @roryabraham in the slack thread if he can take a look at it, as he worked on this optimistic stuff recently.

[roryabraham]

Let me see what I can find out

[roryabraham]

I'm so far unable to reproduce this while using the Settle up elsewhere payment method. Going to try provisioning bank accounts and see if it's related to the PayWithExpensify flow

[roryabraham]

Ok, was able to reproduce using the PayWithExpensify flow:

Here's the failed IOU reportAction:

[roryabraham]

Maybe a red herring, but AFAICT this is the only IOU reportAction where originalMessage.IOUReportID is a string instead of a number. Also, I see that @Julesssss is correct that it's the only one that re-used an existing IOUReportID from an IOU report that's already settled.

[roryabraham]

So I think it's probable that this is related to the PayMoneyRequest flows somewhere.

[roryabraham]

Documenting my testing/investigation:

1. I have two accounts A and C, both with bank accounts added, and wallets upgraded to Gold. These accounts had never chatted before.

2. A uses global create to request money from C. Looking at the IOUReportAction on their newly created chat report:

   

   Then also at the IOU report:

   

3. Then, as C, I paid the IOU report via my Expensify wallet:

   There's a new IOU pay action:

   

   As user A, I see the same pay action:

   

   The IOU report is MANUALREIMBURSED:

   

   User A sees the same thing:

   

   I do see a stacktrace in server logs, not sure if these are a red herring:

   2023-05-10T22:14:37.363137+00:00 expensidev2004 php-fpm: Wtdoxt /api.php [email protected] !ecash1.3.12-1! ?api? [info] [trace] StackTrace start
   2023-05-10T22:14:37.363141+00:00 expensidev2004 php-fpm: Wtdoxt /api.php [email protected] !ecash1.3.12-1! ?api? [info] [trace] 0/4. file '/vagrant/Web-Expensify/lib/Push/API.php' function 'traceFunctionCall' line '253'
   2023-05-10T22:14:37.363145+00:00 expensidev2004 php-fpm: Wtdoxt /api.php [email protected] !ecash1.3.12-1! ?api? [info] [trace] 1/4. file '/vagrant/Web-Expensify/lib/Push/API.php' function 'send' line '159'
   2023-05-10T22:14:37.363149+00:00 expensidev2004 php-fpm: Wtdoxt /api.php [email protected] !ecash1.3.12-1! ?api? [info] [trace] 2/4. file '/vagrant/Web-Expensify/lib/ReportUtils.php' function 'sendToUserChannelByAccountID' line '1990'
   2023-05-10T22:14:37.363156+00:00 expensidev2004 php-fpm: Wtdoxt /api.php [email protected] !ecash1.3.12-1! ?api? [info] [trace] 3/4. file '/vagrant/Web-Expensify/lib/ReportAPI.php' function 'notifyParticipants' line '4004'
   2023-05-10T22:14:37.363160+00:00 expensidev2004 php-fpm: Wtdoxt /api.php [email protected] !ecash1.3.12-1! ?api? [info] [trace] 4/4. file '/vagrant/Web-Expensify/api.php' function 'payWithWallet' line '2866'
   2023-05-10T22:14:37.363164+00:00 expensidev2004 php-fpm: Wtdoxt /api.php [email protected] !ecash1.3.12-1! ?api? [info] [trace] StackTrace end
   

4. Now user C is going to request money from user A (offline first):

   And we see that the IOUReportID of the already-settled IOU is used 💥

   

[roryabraham]

Opened a PR to fix this issue: https://github.com/Expensify/Web-Expensify/pull/37386

[roryabraham]

Thanks @Julesssss for helping take the PR over the finish line here. It was a back-end fix so no C+ payment here. Closing this out.

[trjExpensify]

Nice one, guys!