Hitting enter on an empty field selects the next contact

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to workspace manage members page
2. Click on "Invite"
3. Focus inside the search field
4. Hit enter

Expected Result:

Hitting enter on an empty search field should not select any contact and proceed to the next page

Actual Result:

Hitting enter inside of an empty search field selects a contact and moves on to the next page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.11.2
Reproducible in staging?: y
Reproducible in production?: new feature in invite members page
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230507_161113_Chrome.mp4

az_recorder_20230508_134347.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683465329596899

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In workspace member invitation page, when we press the "Enter" key while the search field is empty, it will choose a contact and proceed to the following page. I'm not sure if this is intentional or not, but this is also happening on web and safari.

What is the root cause of that problem?

The current logic in BaseOptionSelector is selecting the default option, even when the text is empty.

What changes do you think we should make in order to solve the problem?

Adding a conditional statement in BaseOptionSelector to check if the text value is empty will solve the issue.

+                if (this.textInput.value !== '') 
                    this.selectRow(focusedOption);

Additionally, we should add a similar check for the Ctrl+Enter action.

What alternative solutions did you explore? (Optional)

None

Records

Working well after the fix

working-android-18598.webm

[Pujan92]

IMO this is not a bug as the first option is focused and it should get selected on Enter or Ctrl+Enter

[alexpensify]

I'll try to test soon.

[alexpensify]

I agree here that this isn't a bug. Thank you everyone here for participating.