[$1000] Chat - Keyboard is hidden when editing the message and selecting the emoji

[kbecciv]

Closed as dupe of #15992 (comment)

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Go to any chat
4. Type and send any message
5. Open context menu (long-hold on the message)
6. Select Edit option
7. Tap on any emoji

Expected Result:

After selecting an emoji (or dismissing the emoji menu), the keyboard should reappear so that you can continue editing the message

Actual Result:

After selecting an emoji (or dismissing the emoji menu), the keyboard is hidden and you have to tap back into the compose field to edit the message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.10.2

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230504_163106_New.Expensify.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c9bdec3cd07f91a5
• Upwork Job ID: 1654576988630274048
• Last Price Increase: 2023-05-05

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

@kbecciv what does "Hold the finger and open content menu" mean?

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @zanyrenney is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[laurenreidexpensify]

@conorpendergrast - am unsure on the repro steps here as I can't repro and don't understand the phrase being use, and I am OOO on mon as are you (why did you, me an @zanyrenney all get assigned this at Fri 5:30pm when all our calendars say 0% Monday I do not know) and then afk with Accountex stuff from Tues - Thurs, so to move this one along when we get confirmation on what this repro step means an reassigning.

[conorpendergrast]

@laurenreidexpensify Ah, it's the context menu - long press on the sent message! I have it replicated now

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c9bdec3cd07f91a5

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When editing a message in the report, after selecting an emoji from the emoji menu, the edit input does not regain focus.

What is the root cause of that problem?

The composer does not regain focus because the emoji menu still has focus during its hide animation. Calling the focus() method while this animation is playing will not have any effect.

What changes do you think we should make in order to solve the problem?

Implement a delayed focus() method similar to the one in ReportActionsCompose.

https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose.js#L544-L567

Call this focus method with the delay parameter astrue in the onModalHide event handler for EmojiPickerButton in the ReportActionItemMessageEdit component.

https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionItemMessageEdit.js#L332

onModalHide={() => this.focus(true)}

Alternatively, just use a setTimeout method in the onModalHide handler:

onModalHide={() => InteractionManager.runAfterInteractions(() => setTimeout(() => this.textInput.focus(), 100))}

What alternative solutions did you explore? (Optional)

None.

[parasharrajat]

I think we are solving this problem at the root in some issue. Can't find it.

[rojiphil]

@parasharrajat I think, you are referring to this tracking issue

[parasharrajat]

Yes, thanks. We can close this as it is a duplicate of one the mentioned issues on the tracking issue.

[conorpendergrast]

Sounds good to me. @marcochavezf if you disagree, please reopen!