Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - OldDot Transition - New Workspace is not created after tapping "Set up my company for free" #17713

Closed
1 of 6 tasks
kbecciv opened this issue Apr 20, 2023 · 8 comments
Closed
1 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Apr 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go https://staging.expensify.com/
  2. Login with expensifail account
  3. Tap "Set up my company for free"

Expected Result:

NewDot should be opened, and new workspace should be created

Actual Result:

New workspace is not created.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.2.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6025383_video_11.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Apr 20, 2023
@kbecciv
Copy link
Author

kbecciv commented Apr 20, 2023

Issue is not reproductible in production

video_25.mp4

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@danieldoglas
Copy link
Contributor

@kbecciv

What we do in this flow;

  • If an account already has a free policy, it will take the user to the workspaces list
  • If not, it will take the user to the "new workspace" flow.

Looks to me like the account you tested in staging already had a free policy, so the flow is not wrong IMO. Can you confirm that?

Thanks!

@mountiny
Copy link
Contributor

Yeah I agree with @danieldoglas here, I think the view you are testing here is mainly for when user does not have workspace yet, I have tested creating a new workspace from OldDot being deeplinked to new dot and that worked well.

I think we can remove the deploy blocker here and investigate if all is fine with the android chrome, we might close this eventually

@mountiny mountiny added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Apr 20, 2023
@danieldoglas
Copy link
Contributor

So:

  • The first video is not taking to the new workspace screen because they already had an existing policy (and oldDot "knew" it)
  • The second video takes them to the new screen the first time because they didn't have a free policy (and oldDot new they didn't), and the second time it creates a new one because oldDot was not refreshed, so it still didn't know there was a new free policy created when it was clicked.

@mvtglobally
Copy link

mvtglobally commented Apr 20, 2023

So we can close this issue, or there is anything specific on Android you want us to add? Do you need a new full flow video?

@danieldoglas
Copy link
Contributor

IMO yes, closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants