[HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with expensifail account
3. Turn off your internet connection
4. Open Settings > Workspaces
5. Open any existing workspace or create a new one
6. Open General Settings.
7. Press the Name field.
8. Press the Default currency field.
9. Select any currency > Press save
10. Go back online and wait a few seconds

Expected Result:

After returning to online, no errors should appear.

Actual Result:

After go back online, errors appear in the console.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows/ Chrome
• MacOS / Desktop

Version Number: 1.3.2.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6024516_Recording__511.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Seems like this issue might be related #17684 the error does not appear in production

[mountiny]

Seems like we also have the Global create not opening by default on new account and the console error is showing too which will most likely be related.

[mountiny]

cannot reproduce this issue locally either (using the steps in the issue body)

[mountiny]

PR is in a review and going to staging

[mvtglobally]

Issue is fixed https://user-images.githubusercontent.com/43995119/233428431-558c5195-b0a3-4b8c-bb4f-7c24085d280f.MOV

[mountiny]

Thank you @mvtglobally closing

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.2-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Use local SVG for concierge icon" #17697

If no regressions arise, payment will be issued on 2023-04-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.3-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Use local SVG for concierge icon" #17697

If no regressions arise, payment will be issued on 2023-04-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty