Chat - Error message is not showing after toggle off "Simulate failing network requests"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #17444

Action Performed:

1. Go to Settings>Preferences and toggle on "Simulate failing network requests"
2. Open any chat
3. Send an image attachment
4. Wait for a few seconds (I think 3 seconds is enough)
5. Go back to Settings>Preferences and toggle off "Simulate failing network requests"
6. Go to the previous chat and wait until the error shows
7. Verify there is a red dot in LHN

Expected Result:

Error message is showing after toggle off "Simulate failing network requests"

Actual Result:

Error message is not showing after toggle off "Simulate failing network requests"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.1.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

17444.Android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @bernhardoj seems like this was notice during QA of your PR, would you be bale to check this out please?

cc @0xmiroslav and @neil-marcellini

[bernhardoj]

I can reproduce this even before the PR is merged. So, while working on the PR, the error never shows on Android, so I did some changes just to always trigger the error. This looks like a buggy behavior of Simulate failing network request itself. I also feel weird that the error does not show while Simulate failing network request is on. We need to toggle it off to show the error.

[0xmiros]

Same thought as @bernhardoj, not regression.
I couldn't reproduce this as well on android device.
Actually I don't think this is worth fixing since it's just simulation. This shouldn't happen to real users.

[neil-marcellini]

Yes I agree this is not a regression and I don't think it's a good use of our time right now to fix "simulate failing networks requests".