Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Workspace - Error message is missing for UpdateWorkspaceCustomUnit #17576

Closed
4 of 6 tasks
kbecciv opened this issue Apr 18, 2023 · 14 comments
Closed
4 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Apr 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #16564

Action Performed:

  1. Go https://staging.new.expensify.com/ and login
  2. Go to Workspace \ Reimburse expenses
  3. Change the distance unit in quick succession

Expected Result:

Single error message should be displayed

Actual Result:

Error message is missing for UpdateWorkspaceCustomUnit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.1.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6022335_video_47.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018e97b0838aa3492c
  • Upwork Job ID: 1650575811469389824
  • Last Price Increase: 2023-04-24
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 18, 2023
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@stephanieelliott
Copy link
Contributor

Hey @kbecciv Im not sure I understand this one -- changing the distance is a valid action on the workspace, why should we expect that an error message appear?

@kbecciv
Copy link
Author

kbecciv commented Apr 21, 2023

Linked PR #16564 above was introduced the behaviour

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2023
@MelvinBot
Copy link

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@stephanieelliott
Copy link
Contributor

Got it, thanks @kbecciv!

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2023
@stephanieelliott stephanieelliott added the External Added to denote the issue can be worked on by a contributor label Apr 24, 2023
@melvin-bot melvin-bot bot changed the title Workspace - Error message is missing for UpdateWorkspaceCustomUnit [$1000] Workspace - Error message is missing for UpdateWorkspaceCustomUnit Apr 24, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~018e97b0838aa3492c

@MelvinBot
Copy link

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 24, 2023
@MelvinBot
Copy link

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny
Copy link
Contributor

Is this just the replay effect in action again?

@marcaaron
Copy link
Contributor

@s77rt are you able to help triage this one a bit further? We haven't gotten any movement or proposals here and I'm wondering what the next steps should be.

@s77rt
Copy link
Contributor

s77rt commented Apr 26, 2023

@mountiny The replay effect exists here yes but it's unrelated.

@marcaaron This is not a bug. It's confusion by the tests on this #16564. "Verify you see a single error message" This should have been "In case an error occurs, verify you see a single error message".

I think we can close this.

@marcaaron
Copy link
Contributor

Cool. Yes, I agree with the assessment, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants