Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD FOR PAYMENT 05-16-23] Task Details View #17468

Closed
thienlnam opened this issue Apr 14, 2023 · 23 comments
Closed

[HOLD FOR PAYMENT 05-16-23] Task Details View #17468

thienlnam opened this issue Apr 14, 2023 · 23 comments
Assignees
@thienlnam @muttmuure @0xmiros
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Apr 14, 2023 •
edited by melvin-bot bot
Loading

https://docs.google.com/document/d/1uFj0Oh9qtFJ-EH-lg00oMflo8uhkV2yXUT8Tbg6cKws/edit#bookmark=id.3fqqc2c9s4na

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b0a8f01d669eda58
  • Upwork Job ID: 1651373825784291328
  • Last Price Increase: 2023-04-26
@thienlnam thienlnam added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 14, 2023
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot

This comment was marked as off-topic.

Sign in to view
@thienlnam thienlnam removed the Bug Something is broken. Auto assigns a BugZero manager. label Apr 14, 2023
@thienlnam thienlnam assigned thienlnam and unassigned thienlnam Apr 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@thienlnam
Copy link
Contributor Author

Working with IR on this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 17, 2023
@thienlnam thienlnam changed the title Task Details View [HOLD] Task Details View Apr 20, 2023
@thienlnam
Copy link
Contributor Author

thienlnam commented Apr 20, 2023 •
edited
Loading

Putting this on hold as it might change a bit depending on the design changes in https://github.com/Expensify/Expensify/issues/276726

@melvin-bot melvin-bot bot removed the Overdue label Apr 20, 2023
@thienlnam thienlnam changed the title [HOLD] Task Details View Task Details View Apr 21, 2023
@thienlnam
Copy link
Contributor Author

The icon / profile view is still under discussion, but the new mockups are mostly finalized and can be worked on

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2023
@thienlnam
Copy link
Contributor Author

Going to get started on this, and will hand off the PR to IR if needed

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2023
@thienlnam thienlnam mentioned this issue Apr 24, 2023
Merged
55 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 24, 2023
@thienlnam thienlnam added Internal Requires API changes or must be handled by Expensify staff and removed Reviewing Has a PR in review labels Apr 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 26, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01b0a8f01d669eda58

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Apr 26, 2023
@MelvinBot
Copy link

@thienlnam, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@0xmiros
Copy link
Contributor

0xmiros commented May 4, 2023

Not overdue. PR deployed to staging today.

@thienlnam thienlnam mentioned this issue May 10, 2023
Merged
57 tasks
@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

@thienlnam, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@0xmiros
Copy link
Contributor

0xmiros commented May 12, 2023

The first PR hit production on May 9.

@thienlnam thienlnam added the NewFeature Something to build that is a new item. label May 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 12, 2023
@thienlnam thienlnam changed the title Task Details View [HOLD FOR PAYMENT 05-16-23] Task Details View May 12, 2023
@thienlnam
Copy link
Contributor Author

Assigning BZ so they can issue payment once the 7 day prod period has passed

@muttmuure
Copy link
Contributor

7 days passed

@0xmiros
Copy link
Contributor

0xmiros commented May 17, 2023

This issue is linked to 2 PRs
Compensation for first PR is due on May 16 (for me)
Compensation for 2nd PR is due on May 23 (for @fedirjh)

@0xmiros
Copy link
Contributor

0xmiros commented May 17, 2023

Oh actually, there's another GH created for 2nd PR - #18785

@0xmiros
Copy link
Contributor

0xmiros commented Jun 1, 2023

@muttmuure friendly bump for payment
Reviewing label still exists, that's why not Overdue forever

@muttmuure
Copy link
Contributor

Sorry I missed this! I was out of office for a couple of weeks

@muttmuure
Copy link
Contributor

@0xmiroslav and @eVoloshchak invited for the first PR. Job is called Tasks Detailed View #17940

@muttmuure
Copy link
Contributor

Paid up

@thienlnam
Copy link
Contributor Author

@muttmuure There isn't supposed to be a payment here for @eVoloshchak, they did not do a review of the first PR #17940

@thienlnam thienlnam reopened this Jun 13, 2023
@muttmuure
Copy link
Contributor

Ah, weirdly I tagged them but I didn't pay them. I think this is all sorted.

Sorry for the confusion @eVoloshchak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thienlnam thienlnam

@muttmuure muttmuure

@0xmiros 0xmiros

Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@MelvinBot @thienlnam @muttmuure @Christinadobrzyn @0xmiros