Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-04-07 #17160

Closed
23 tasks done
OSBotify opened this issue Apr 7, 2023 · 5 comments
Closed
23 tasks done

Deploy Checklist: New Expensify 2023-04-07 #17160

OSBotify opened this issue Apr 7, 2023 · 5 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 7, 2023

Release Version: 1.2.97-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 8, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 8, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.97-2 🚀

@mvtglobally
Copy link

Regression is completed

BLockers
#17185
#17190

We are retesting #17079 based on updated steps.
Can we check off this one #16949 (comment) ?

@francoisl francoisl self-assigned this Apr 10, 2023
@francoisl
Copy link
Contributor

Can we check off this one #16949 (comment) ?

Yes I'll check this one off and make a note to test on production.

Looking into the other blockers now.

@francoisl
Copy link
Contributor

The last two blockers are reproducible in production so let's go forward with the deploy.

Noting that I see one new ANR in Firebase for 1.2.97-2 but it seems like a one-off issue, I don't think we need to block on this.

SpannedString.getSpanFlags
ANR triggered by slow operations in main thread

@francoisl
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants