Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-04-06 #16996

Closed
16 tasks done
OSBotify opened this issue Apr 6, 2023 · 6 comments
Closed
16 tasks done

Deploy Checklist: New Expensify 2023-04-06 #16996

OSBotify opened this issue Apr 6, 2023 · 6 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 6, 2023

Release Version: 1.2.96-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 6, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 6, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.96-3 🚀

@mvtglobally
Copy link

PR #16773 is failing #17108

@mvtglobally
Copy link

@thienlnam
Regression is completed

Double check blockers

[HOLD for payment 2023-04-13] [HOLD for payment 2023-04-12] Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. #16897
[HOLD for payment 2023-04-13] [HOLD for payment 2023-04-12] Composer hidden while showing skeleton after login #16908
Clicking on deep links on passwordless crashes the app #17091

@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 7, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.96-4 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 7, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.96-4 has been deployed to staging 🎉

@thienlnam
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants