Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold on #15992] Composer not focused when user leaves/returns an ongoing DM draft #16699

Closed
2 of 6 tasks
kavimuru opened this issue Mar 29, 2023 · 24 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. go to any chat
  2. click on composer
  3. click on users name to see the details
  4. close the details page

Expected Result:

composer should focused (same as web, mWeb)

Actual Result:

composer not focused

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.91-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

az_recorder_20230329_150759.1.mp4
Screen_Recording_20230329_164112_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680088305065359

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 29, 2023
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2023
@MelvinBot
Copy link

@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

@michaelhaxhiu
Copy link
Contributor

@bondydaa do you think we should close this GH or keep it on hold for #15992?

@melvin-bot melvin-bot bot removed the Overdue label Apr 5, 2023
@michaelhaxhiu
Copy link
Contributor

@michaelhaxhiu
Copy link
Contributor

Holding till we hear back. This is valid but it may be better to consolidate with the tracking GH.

@bondydaa
Copy link
Contributor

bondydaa commented Apr 6, 2023

I think the SOP has been to put a HOLD on any issues created and link it on the tracking GH.

@michaelhaxhiu
Copy link
Contributor

michaelhaxhiu commented Apr 7, 2023

Excellent, let's do the same here. Thanks Bondy :)

This job is on hold for #15992

@michaelhaxhiu michaelhaxhiu changed the title composer not focused when user return from user details page Composer not focused when user leaves/returns an ongoing DM draft Apr 7, 2023
@michaelhaxhiu michaelhaxhiu changed the title Composer not focused when user leaves/returns an ongoing DM draft [Hold] Composer not focused when user leaves/returns an ongoing DM draft Apr 7, 2023
@michaelhaxhiu michaelhaxhiu added Weekly KSv2 and removed Daily KSv2 labels Apr 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@michaelhaxhiu
Copy link
Contributor

held for now

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 27, 2023
@michaelhaxhiu
Copy link
Contributor

holding, still ⏸️

@melvin-bot melvin-bot bot removed the Overdue label Apr 28, 2023
@melvin-bot melvin-bot bot added the Overdue label May 8, 2023
@michaelhaxhiu
Copy link
Contributor

stil held

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@melvin-bot melvin-bot bot added the Overdue label May 16, 2023
@michaelhaxhiu
Copy link
Contributor

Still held, commented on blocking GH to see if we have any indication of prioritization on this one.

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 27, 2023
@michaelhaxhiu
Copy link
Contributor

still held

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@michaelhaxhiu michaelhaxhiu added Monthly KSv2 and removed Weekly KSv2 labels Jul 11, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2023
@michaelhaxhiu michaelhaxhiu changed the title [Hold] Composer not focused when user leaves/returns an ongoing DM draft [Hold on #15992] Composer not focused when user leaves/returns an ongoing DM draft Aug 3, 2023
@michaelhaxhiu
Copy link
Contributor

Note: I'm preparing to go OOO for ~2 weeks, and doubt this will see movement while I'm gone. I'm going to keep it assigned for that reason and not add a buddy. If it gets movement (and I'm wrong), please remove & reapply the bug label.

@michaelhaxhiu
Copy link
Contributor

Back from OOO. Still no movement.

@michaelhaxhiu
Copy link
Contributor

Not a priority yet.

@michaelhaxhiu michaelhaxhiu removed their assignment Sep 27, 2023
@michaelhaxhiu michaelhaxhiu added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Sep 27, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Sep 27, 2023
@michaelhaxhiu michaelhaxhiu added Monthly KSv2 and removed Daily KSv2 labels Sep 27, 2023
@michaelhaxhiu
Copy link
Contributor

I'm re-assigning the Bug label to get a new BZ on this, as my sabbatical starts Friday.

Next steps:

Thanks in advance!

@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@muttmuure
Copy link
Contributor

Not a priority yet

@melvin-bot melvin-bot bot removed the Overdue label Nov 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2023
@muttmuure
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2023
@mountiny
Copy link
Contributor

Discussing with @muttmuure I think we can close this one in light of focus on waves and roadmap issues. It is also correctly linked in the tracking issue if we need to come back to this in future. Feel free to reopen if you disagree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants