Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-09-06] [$250] Migrate OnfidoPrivacy.js to function component #16234

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 56 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0192fbde0c3af746a3
  • Upwork Job ID: 1689721648652472320
  • Last Price Increase: 2023-08-17
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate OnfidoPrivacy.js to function component [HOLD][$250] Migrate OnfidoPrivacy.js to function component Apr 13, 2023
@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@dummy-1111
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@vdem0115
Copy link

vdem0115 commented Jul 5, 2023

I would like to work on this.

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@payal-lathidadiya
Copy link
Contributor

I'd like to work on this

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@to-ai
Copy link

to-ai commented Jul 11, 2023

I am able to work on this task.

@neonbhai
Copy link
Contributor

I would love to work on this

@KrAbhas
Copy link
Contributor

KrAbhas commented Jul 19, 2023

I would like to work on this

@BartoszGrajdek
Copy link
Contributor

Hey! I’m from Software Mansion, an expert agency, and I’d like to work on this issue.

@melvin-bot
Copy link

melvin-bot bot commented Aug 10, 2023

📣 @BartoszGrajdek! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@marcaaron marcaaron added NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. labels Aug 10, 2023
@marcaaron marcaaron self-assigned this Aug 10, 2023
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Aug 10, 2023
@alexxxwork
Copy link
Contributor

dibs

@ghost
Copy link

ghost commented Aug 10, 2023

Dibs

@marcaaron marcaaron changed the title [HOLD][$250] Migrate OnfidoPrivacy.js to function component [$250] Migrate OnfidoPrivacy.js to function component Aug 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 10, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0192fbde0c3af746a3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 10, 2023

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 18, 2023
@dylanexpensify
Copy link
Contributor

we're moving!

@dylanexpensify
Copy link
Contributor

Nice! Waiting for 7-day period to pass then payment!

@BartoszGrajdek
Copy link
Contributor

Hey! I’m from Software Mansion, an expert agency, and I’d like to work on this issue.

@dylanexpensify no payment in this case ;)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 30, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate OnfidoPrivacy.js to function component [HOLD for payment 2023-09-06] [$250] Migrate OnfidoPrivacy.js to function component Aug 30, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@marcaaron, @BartoszGrajdek, @dylanexpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@marcaaron, @BartoszGrajdek, @dylanexpensify, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

@dylanexpensify
Copy link
Contributor

Perfect! @thesahindia payment owed: $250 - is this via ND or Upwork?

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@thesahindia
Copy link
Member

Requested via ND 👍🏼

@dylanexpensify
Copy link
Contributor

Perfect!

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@marcaaron
Copy link
Contributor Author

Are we good to close this one out?

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2023
@dylanexpensify
Copy link
Contributor

yes!

@JmillsExpensify
Copy link

$250 payment for @thesahindia approved based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests