Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-12] [$250] Migrate IdologyQuestions.js to function component #16233

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 20 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01395e41039b03d05d
  • Upwork Job ID: 1705098274459115520
  • Last Price Increase: 2023-09-22
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate IdologyQuestions.js to function component [HOLD][$250] Migrate IdologyQuestions.js to function component Apr 13, 2023
@dummy-1111
Copy link
Contributor

I'd love to work on this.

@neonbhai
Copy link
Contributor

neonbhai commented Jun 9, 2023

I can work on this if this opens up!

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@to-ai
Copy link

to-ai commented Jul 11, 2023

I am able to work on this task.

@KrAbhas
Copy link
Contributor

KrAbhas commented Jul 19, 2023

I would like to work on this

@barttom
Copy link
Contributor

barttom commented Sep 21, 2023

Hello!
I'm Bartek from Callstack - an expert contributor group and I would like to work on this one.

@marcaaron marcaaron changed the title [HOLD][$250] Migrate IdologyQuestions.js to function component [$250] Migrate IdologyQuestions.js to function component Sep 22, 2023
@marcaaron marcaaron added External Added to denote the issue can be worked on by a contributor and removed Improvement Item broken or needs improvement. labels Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01395e41039b03d05d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

@marcaaron marcaaron removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 22, 2023
@ghost
Copy link

ghost commented Sep 22, 2023

Dibs

1 similar comment
@alexxxwork
Copy link
Contributor

Dibs

@nebiyuelias1
Copy link

Dibs

@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2023
@marcaaron
Copy link
Contributor Author

This can be a weekly. We are just waiting for a PR.

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@marcaaron marcaaron added Weekly KSv2 and removed Daily KSv2 labels Sep 25, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Sep 26, 2023
@mountiny mountiny assigned narefyev91 and unassigned ArekChr Sep 26, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 5, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate IdologyQuestions.js to function component [HOLD for payment 2023-10-12] [$250] Migrate IdologyQuestions.js to function component Oct 5, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @barttom does not require payment (Contractor)
  • @narefyev91 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 11, 2023
@adelekennedy
Copy link

@marcaaron - is any Upwork/NewDot payment required here? It doesn't look like it to me

@melvin-bot melvin-bot bot removed the Overdue label Oct 13, 2023
@marcaaron
Copy link
Contributor Author

I agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests