Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-08] [$250] Migrate Picker.js to function component #16189

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 50 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

  • src/components/Picker/Picker.js
    • type: React.PureComponent
    • has state values: true
    • has refs: true
    • has context: false
    • lifecycle methods: componentDidMount,componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ab92da023f998e29
  • Upwork Job ID: 1678837491382091776
  • Last Price Increase: 2023-07-11
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate Picker.js to function component [HOLD][$250] Migrate Picker.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@dummy-1111
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 9, 2023

Can I work on this?

@marcaaron marcaaron changed the title [HOLD][$250] Migrate Picker.js to function component [$250] Migrate Picker.js to function component Jul 11, 2023
@marcaaron marcaaron added Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ab92da023f998e29

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@rayane-d
Copy link
Contributor

Can I work on this issue?

@alexxxwork
Copy link
Contributor

I would love to work on this issue

@rayane-d
Copy link
Contributor

Can I work on this issue?

@yh-0218
Copy link
Contributor

yh-0218 commented Jul 11, 2023

I can work on this task. Thanks.

@crazy-coding
Copy link

I'd love to work on this.

1 similar comment
@Talha345
Copy link
Contributor

I'd love to work on this.

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@vadymbokatov
Copy link
Contributor

I'd love to work on this issue

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

📣 @vadymbokatov! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Vadym-33
Copy link

I hope to work on this task.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Aug 1, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate Picker.js to function component [HOLD for payment 2023-08-08] [$250] Migrate Picker.js to function component Aug 1, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Aug 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

@cubuspl42, @youssef-lr, @mallenexpensify 12 days overdue now... This issue's end is nigh!

@mallenexpensify
Copy link
Contributor

Contributor: @cubuspl42 paid $250 via Upwork, sorry it took so long.

@aimane-chnaif
Copy link
Contributor

@mallenexpensify C+ payment is pending

@aimane-chnaif
Copy link
Contributor

C+ payment is pending

@mallenexpensify kindly bump ^

@mallenexpensify
Copy link
Contributor

@aimane-chnaif sorry I missed this, didn't see ya assigned, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~016c80bcf21e793cbc

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@youssef-lr
Copy link
Contributor

Not overdue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 9, 2023
@aimane-chnaif
Copy link
Contributor

@aimane-chnaif sorry I missed this, didn't see ya assigned, can you please accept the job and reply here once you have?

@mallenexpensify Accepted already, thanks

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@youssef-lr
Copy link
Contributor

We good to close?

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@aimane-chnaif
Copy link
Contributor

Still waiting for approval on upwork
cc: @mallenexpensify

@mallenexpensify
Copy link
Contributor

Contributor+: @aimane-chnaif paid $250 via Upwork!

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests