[HOLD for payment 2023-04-04] [$1000] Settings - An account stays in English after changing the language to Spanish on the login page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #15169

Action Performed:

1. Open the App
2. At the login page change the language to Spanish
3. log in to account
4. Pay attention to account language, it should be changed to Spanish

Expected Result:

An account becomes in Spanish after changing the language to Spanish on the login page

Actual Result:

An account stays in English after changing the language to Spanish on the login page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.73.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5941881_Record_2023-02-17-16-35-16_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019bd34580285adc50
• Upwork Job ID: 1626640192677289984
• Last Price Increase: 2023-02-17

[MelvinBot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lschurr]

I was able to reproduce on staging. Adding eng for another pair of eyes and whether this should be Internal or External.

[MelvinBot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[puneetlath]

Ah that's pretty interesting. So the language selector on the sign in pages only applies to the sign in pages and doesn't carry over into the account once you sign in. I could see the argument that it should. Why would you switch to spanish there if you didn't also want it in the account.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~019bd34580285adc50

[MelvinBot]

Current assignees @puneetlath and @lschurr are eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[s77rt]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Signing in overrides the set language on login page with the account's preferred language.

What is the root cause of that problem?

OpenApp API response contains an onyx instruction targeting preferredLocale.

What changes do you think we should make in order to solve the problem?

None. Personally I don't think this is a problem. This is arguably a feature.

What alternative solutions did you explore? (Optional)

None

[puneetlath]

Yes, I think you could argue it's a feature. But at least for a new user, landing on our site for the first time. If they set the site to spanish on the login page, it'd be nice for that to carry through.

[s77rt]

@puneetlath I see your point however fixing this would mean to make the preferredLocale a client only value so we need to recheck why this was decided to be managed by the server in the first place. FWIW PayPal also behaves the same way and I think many websites do the same.

[puneetlath]

Yeah I think you're right that it's probably not worth changing. Thanks for always being willing to push for closing the issue!

Anyone else, feel free to reopen if you disagree.

[s77rt]

@puneetlath

But at least for a new user, landing on our site for the first time. If they set the site to spanish on the login page, it'd be nice for that to carry through.

For new user who is just signing up, his account should be created with the set language on the login(register) page so when he sign in, the language would be as expected. I don't know if this is already the behaviour or if it always create new accounts with English set as default. Other than that case I think we made the right choice closing the issue.

[0xmiros]

I think this is correct scenario:

• When user first install the app, language should depend on device locale. So if device language is Spanish, Spanish should be selected as default value of picker on login page
• Enter new email and create new account
• Email should be in Spanish
• After clicking link, magic code or enter new password page should be in Spanish

No such features implemented in current app right now.

I also tried to set language manually on Enter new password page and then after login, it changes back to English on main page.
So right now, language is 100% based on user preference in account setting. If not set, always fallback to English.
So for new Spanish users, it's annoying that they should select language on each step until they reach Settings -> Preferences -> Language page.

[puneetlath]

I agree, that is annoying and what you describe would be the ideal behavior. However, I think that's more of a feature request than a bug, so I think it's ok for us to leave this closed for now. We can always improve the non-english experience in the future.

[MelvinBot]

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

[MelvinBot]

@puneetlath @lschurr @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[lschurr]

Just reopened this. Waiting for proposals.

[0xmiros]

Since this requires backend update, @puneetlath marked this as Internal.
But @lschurr you mean you're going to open this to External since this also involves frontend fix?

[lschurr]

Oh, nope, missed that. Looks like it's staying internal.

[puneetlath]

Both PRs have been merged.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.90-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Pass preferred locale to API on sign in #16326

If no regressions arise, payment will be issued on 2023-04-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav / @puneetlath] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav / @puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav / @puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@puneetlath / @lschurr] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath / @lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/273534

[lschurr]

@puneetlath @0xmiroslav - do we need a regression test for this?

[lschurr]

I created a new job since the old one expired. @0xmiroslav will you apply here - https://www.upwork.com/jobs/~01a4e4a8b467f55ab8

[0xmiros]

I created a new job since the old one expired. @0xmiroslav will you apply here -

The job is private so cannot apply. Can you please invite me to the job?

[0xmiros]

@puneetlath @0xmiroslav - do we need a regression test for this?

Since this is kind of a new feature, no PR which caused regression.
QA Step in PR can be used for regression test steps.

[lschurr]

Invited @0xmiroslav to the job.

[lschurr]

Payment issued. I think we can close this one.