Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments - Different error message appears when adding same bank account again #13849

Closed
6 tasks
kbecciv opened this issue Dec 28, 2022 · 7 comments
Closed
6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #11837

Action Performed:

  1. Go to Settings > Payment > Add Payment Method > Bank Account
  2. Add a test Plaid account (e.g. Chase with credentials user_good / pass_good / blank OTP)
  3. Make sure you see the success page saying that the account was added
  4. Repeat the same flow and try to add the same bank account again

Expected Result:

When you're redirected back to Expensify, make sure you get the Sorry, no bank account is available

Actual Result:

Could not find any bank accounts that you haven't already added message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.44.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5878005_desktop_11837.mp4

Screen Shot 2022-12-27 at 5 07 30 PM

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 28, 2022
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 28, 2022
@marcochavezf
Copy link
Contributor

It seems the message is the expected one, asking for clarification here #11837 (comment)

@srikarparsi
Copy link
Contributor

Hey @marcochavezf, yes this is the expected error message - we modified it to use the error message from Web E since it was more specific. I'm trying to find the flow in test rail to modify it but couldn't find anything related to closing an account. @kbecciv would you be able to modify the expected behavior in test rail to the actual result for this flow?

@kbecciv
Copy link
Author

kbecciv commented Dec 29, 2022

@srikarparsi Let me check the TestRail steps first, since this was coming from PR.

@kbecciv
Copy link
Author

kbecciv commented Dec 29, 2022

Tagging for the updates @mvtglobally

@srikarparsi
Copy link
Contributor

Ohh sorry, I thought this was coming from Test Rail but am following now. I just updated the PR to have the right QA steps. I'm not sure if this flow is in Test Rail but it would be great if you could update the expected result if it is :)

@melvin-bot melvin-bot bot added the Overdue label Dec 30, 2022
@marcochavezf
Copy link
Contributor

Cool, since this is the expected error message I think we can close this issue out cc @mallenexpensify

@mallenexpensify
Copy link
Contributor

Agreed, I think the below is what we want

Could not find any bank accounts that you haven't already added message appears

@melvin-bot melvin-bot bot removed the Overdue label Dec 30, 2022
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants