Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Branding] Slight misalignment on composer bar #13595

Closed
shawnborton opened this issue Dec 14, 2022 · 6 comments
Closed

[Core Branding] Slight misalignment on composer bar #13595

shawnborton opened this issue Dec 14, 2022 · 6 comments
Assignees
Labels
Design Monthly KSv2 Reviewing Has a PR in review

Comments

@shawnborton
Copy link
Contributor

We recently made some updates to the composer bar to use rounded edges and different button shapes. It looks like the new adjustments are slightly off though upon closer review:
image
image

Notably, the "Write something..." should be perfectly left aligned with the chat text above.

Here is some x-ray vision to help visualize things:
image

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 14, 2022
@grgia
Copy link
Contributor

grgia commented Dec 14, 2022

Now I can't unsee it 😂

@grgia
Copy link
Contributor

grgia commented Dec 15, 2022

Is the plus icon a different size here too?

@shawnborton
Copy link
Contributor Author

I think my mock has an old icon in it, so you can ignore that - what we have on production is good.

@grgia
Copy link
Contributor

grgia commented Dec 15, 2022

Quick question, should the border be a part of the plus button? I noticed it inherits the onClick color and I want to make sure that's expected

Screen.Recording.2022-12-15.at.4.46.53.PM.mov

@shawnborton
Copy link
Contributor Author

My thinking is no, it would be a separate element. Basically a divider between the plus button and the chat input. But if it already exists like that, it's probably fine to keep as-is... but yeah, semantically, it doesn't feel like part of the plus button.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Monthly KSv2 labels Dec 15, 2022
@grgia
Copy link
Contributor

grgia commented Feb 8, 2023

Closing as completed!

@grgia grgia closed this as completed Feb 8, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants