[HOLD for payment 2022-12-22] [HOLD for payment 2022-12-20] If user tries to Request money after settling, error message is shown

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Pre-Condition: User A has requested money from User B

1. Access staging.new.expensify.com
2. Sign into a valid account (User B)
3. Navigate to the conversation with User A
4. Settle up
5. After settling, request a payment from User A

Expected Result:

User expects the payment request to go through with no issues

Actual Result:

User receives an error message

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5858837_User_can_not_request_money_after_setttling.mp4

Expensify/Expensify Issue URL: 1.2.38-0
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Gonals]

Taking a look!

[youssef-lr]

@Gonals I got a fix for this in the linked issue by @robertjchen, see this Slack convo

[Gonals]

@youssef-lr, Ah, this was a duplicate, I see!

I was actually going to create another one to fix the web side too, so let's just keep both! I think we should be doing both things anyways

[chiragsalian]

QA tested the CP PR and it was a pass, removing deploy blocker label.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Check hasOutstandingIOU in money requests #13522

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR: Refactor createIOUTransaction to RequestMoney #10843
• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor createIOUTransaction to RequestMoney #10843 (comment)
• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1671098242760819
• [@maddylewis] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.39-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Check hasOutstandingIOU in money requests #13522

If no regressions arise, payment will be issued on 2022-12-22. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR:
• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@maddylewis] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[maddylewis]

buddy check if a regression test is needed here - https://expensify.slack.com/archives/C01SKUP7QR0/p1672152149673229

[melvin-bot]

@Gonals, @maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Gonals]

This one got reverted, so checking out all boxes 🤷

[maddylewis]

This one got reverted, so checking out all boxes 🤷

@Gonals does this mean we should close out the issue? or, should I still be adding a regression test to Test Rail?

[Gonals]

Ah, we can close this one. It was kind of a duplicate and it got fixed elsewhere, basically

[maddylewis]

okay, great! thanks for the clarification. ill go ahead and close this one out 👍